Skip to content

Updating apps.json for portal quickstart #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2019
Merged

Updating apps.json for portal quickstart #6

merged 3 commits into from
Nov 7, 2019

Conversation

abhidnya13
Copy link
Contributor

Making logout url https as portal does not accept http value

Copy link

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just verify that signout still works if you register an https logoutUrl

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayluo
Copy link
Contributor

rayluo commented Nov 6, 2019

Agree with @sangonzal . Such change might work around the portal behavior (which we wouild like to file an issue with Portal Team), but that value is semantically incorrect because redirecting to "httpS://localhost/..." would typically fail.

Got an idea. Is it possible to adjust our app creation script instead, to not set that logout url at all? So that we can bypass such issue, rather than hardcode an incorrect workaround.

@abhidnya13
Copy link
Contributor Author

abhidnya13 commented Nov 7, 2019

Tested that signout works irrespective of what logout url is set.

This behaviour is mainly because our sample app still relies on an eSTS feature of redirecting back to a URL specified by post_logout_redirect_uri . The reason we can remove the "logoutUrl" setting from apps.json is that we take advantage of the behavior that eSTS would honor a post_logout_redirect_uri on the fly, regardless of whatever we would configure beforehand.

@abhidnya13 abhidnya13 requested a review from rayluo November 7, 2019 17:57
Copy link

@navyasric navyasric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Readme also has a step to add logout URL. We must remove that step.

@abhidnya13
Copy link
Contributor Author

Thanks @navyasric for pointing that out. I will make the ReadMe change in this PR in the next commit. And that also reminds me that we should regenerate the AppCreation Scripts to reflect this change. I will create a separate PR for updating the sample.json and the new App Creation scripts soon. Will checkin these changes so that there is no blocker for portal team to pick up the updated apps.json

@abhidnya13 abhidnya13 requested a review from navyasric November 7, 2019 18:56
Copy link

@navyasric navyasric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Ship it!

@abhidnya13 abhidnya13 merged commit 8e89f70 into master Nov 7, 2019
@abhidnya13 abhidnya13 deleted the updates branch November 7, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants