-
Notifications
You must be signed in to change notification settings - Fork 148
Updating apps.json for portal quickstart #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just verify that signout still works if you register an https logoutUrl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Agree with @sangonzal . Such change might work around the portal behavior (which we wouild like to file an issue with Portal Team), but that value is semantically incorrect because redirecting to "httpS://localhost/..." would typically fail. Got an idea. Is it possible to adjust our app creation script instead, to not set that logout url at all? So that we can bypass such issue, rather than hardcode an incorrect workaround. |
Tested that signout works irrespective of what logout url is set. This behaviour is mainly because our sample app still relies on an eSTS feature of redirecting back to a URL specified by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Readme also has a step to add logout URL. We must remove that step.
Thanks @navyasric for pointing that out. I will make the ReadMe change in this PR in the next commit. And that also reminds me that we should regenerate the AppCreation Scripts to reflect this change. I will create a separate PR for updating the sample.json and the new App Creation scripts soon. Will checkin these changes so that there is no blocker for portal team to pick up the updated apps.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Ship it!
Making logout url https as portal does not accept http value