Decouple Azure Authentication from Web App [On-Hold] #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Jan 31, 2020
There was a problem hiding this comment.
Hi Greg, thanks for your effort and we understand your point. We do have a similar plan, and we will take your suggestion into consideration. But we would need more time to think on this. Before that, we will probably not merge this PR as-is.
Feel free to use this PR in your project, whenever you see fit.
Also, (partially to show our respect to your time and effort,) we did review your PR carefully. Thank you for one specific finding below.
ugreg
commented
Feb 2, 2020
|
You're very welcome! Thanks to your for putting this together. This sample has been very useful for an app I'm working on for HoloLens Guides. |
rayluo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
AzureAuthclass to showcase how authentication and authorization logic can be decoupled.