Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Fix the token type helper method #299

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix the token type helper method #299

merged 1 commit into from
Apr 20, 2023

Conversation

derisen
Copy link
Contributor

@derisen derisen commented Apr 20, 2023

Purpose

  • Fix the token type helper method where it incorrectly checks for the existence of scp claim

Does this introduce a breaking change?

[ ] Yes
[ x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@derisen derisen requested a review from v-michaelmi April 20, 2023 16:41
Copy link
Contributor

@v-michaelmi v-michaelmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@derisen derisen merged commit 1ce5255 into main Apr 20, 2023
@derisen derisen deleted the fix-api-permission-bug branch April 20, 2023 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants