This repository was archived by the owner on May 17, 2024. It is now read-only.
Update 3.1 to follow BASHER and Zero Trust guidelines #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derisen
changed the title
derisen
requested review from
salman90,
kalyankrishna1,
aremo-ms,
v-michaelmi and
tonyYuhaoYangMcrS
nit:An Angular SPA using MSAL Angular to sign-in users with Azure Active Directory and call a protected .NET Core web API In reply to: 1182140157 In reply to: 1182140157 Refers to: 3-Authorization-II/1-call-api/README.md:1 in 4a60819. [](commit_id = 4a60819, deletion_comment = False) |
3-Authorization-II/1-call-api/AppCreationScripts/README_STEPS.md
Outdated
Show resolved
Hide resolved
this is an outdated link In reply to: 1182164196 In reply to: 1182164196 Refers to: 3-Authorization-II/1-call-api/README.md:40 in 4a60819. [](commit_id = 4a60819, deletion_comment = False) |
| | `API/appsettings.json` | Authentication parameters for API project reside here. | | ||
| | `API/Startup.cs` | Microsoft.Identity.Web is initialized here. | | ||
| | `API/TodoListAPI/appsettings.json` | Authentication parameters for API project reside here. | | ||
| | `API/TodoListAPI/Startup.cs` | Microsoft.Identity.Web is initialized here. | |
| @@ -30,8 +31,9 @@ This sample demonstrates an Angular single-page application (SPA) calling a ASP. | |||
| |-------------------------------------|------------------------------------------------------------| | |||
| | `SPA/src/app/auth-config.ts` | Authentication parameters for SPA project reside here. | | |||
| | `SPA/src/app/app.module.ts` | MSAL Angular is initialized here. | | |||
|
|
||
| ## We'd love your feedback! | ||
|
|
||
| Were we successful in addressing your learning objective? Consider taking a moment to [share your experience with us](https://forms.office.com/Pages/ResponsePage.aspx?id=v4j5cvGGr0GRqy180BHbR73pcsbpbxNJuZCMKN0lURpUOU5PNlM4MzRRV0lETkk2ODBPT0NBTEY5MCQlQCN0PWcu). | ||
|
|
||
| ## About the code | ||
|
|
||
| ### Access token validation | ||
| ### CORS settings |
add tow lines,
In reply to: 1182223110 In reply to: 1182223110 Refers to: 3-Authorization-II/1-call-api/README.md:41 in 4a60819. [](commit_id = 4a60819, deletion_comment = False) |
| In your controller, add [Authorize] decorator, which will make sure all incoming requests have an authentication bearer: | ||
| For validation and debugging purposes, developers can decode **JWT**s (*JSON Web Tokens*) using [jwt.ms](https://jwt.ms). | ||
|
|
||
| ### Verifying permissions |
There was a problem hiding this comment.
brilliant, put this section in Codegen too ! #Closed
|
Aside from a couple of nits LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information