Replaced Volley calls with Graph SDK #50
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,65 @@ | ||||||
| // Copyright (c) Microsoft Corporation. | ||||||
| // All rights reserved. | ||||||
| // | ||||||
| // This code is licensed under the MIT License. | ||||||
| // | ||||||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||||||
| // of this software and associated documentation files(the "Software"), to deal | ||||||
| // in the Software without restriction, including without limitation the rights | ||||||
| // to use, copy, modify, merge, publish, distribute, sublicense, and / or sell | ||||||
| // copies of the Software, and to permit persons to whom the Software is | ||||||
| // furnished to do so, subject to the following conditions : | ||||||
| // | ||||||
| // The above copyright notice and this permission notice shall be included in | ||||||
| // all copies or substantial portions of the Software. | ||||||
| // | ||||||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||||||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||||||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||||||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||||||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||||||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||||||
| // THE SOFTWARE. | ||||||
|
|
||||||
| package com.azuresamples.msalandroidapp; | ||||||
|
|
||||||
| import android.os.Build; | ||||||
|
|
||||||
| import androidx.annotation.RequiresApi; | ||||||
|
|
||||||
| import com.microsoft.graph.authentication.BaseAuthenticationProvider; | ||||||
|
|
||||||
| import java.net.URL; | ||||||
| import java.util.concurrent.CompletableFuture; | ||||||
|
|
||||||
| import javax.annotation.Nonnull; | ||||||
|
|
||||||
| /** | ||||||
| * Implementation sample for a simplistic authentication provider | ||||||
| * <p> | ||||||
| * The Microsoft Graph SDK client accepts an authentication provider | ||||||
| * that is responsible for providing access tokens to authenticate API | ||||||
| * calls. Because this sample focuses on acquiring tokens manually, this | ||||||
| * provider simply returns the provided token. | ||||||
| * <p> | ||||||
| * Real-world providers would take advantage of MSAL's caching abilities | ||||||
| * to always get a valid token, refresh the token when expired, etc. | ||||||
| */ | ||||||
| public class StaticTokenAuthProvider extends BaseAuthenticationProvider { | ||||||
|
|
||||||
| private final String mAccessToken; | ||||||
|
|
||||||
| public StaticTokenAuthProvider(String accessToken) { | ||||||
| mAccessToken = accessToken; | ||||||
| } | ||||||
|
|
||||||
| @RequiresApi(api = Build.VERSION_CODES.N) | ||||||
| @Nonnull | ||||||
|
There was a problem hiding this comment.
Suggested change
Since this method can return There was a problem hiding this comment. Hmm - maybe it would be better to return There was a problem hiding this comment. yep, return a CompletableFuture.completedFuture(null) https://github.com/microsoftgraph/msgraph-sdk-java-core/blob/dev/src/main/java/com/microsoft/graph/httpcore/AuthenticationHandler.java#L54 |
||||||
| @Override | ||||||
| public CompletableFuture<String> getAuthorizationTokenAsync(@Nonnull URL requestUrl) { | ||||||
| if (shouldAuthenticateRequestWithUrl(requestUrl)) { | ||||||
| return CompletableFuture.completedFuture(mAccessToken); | ||||||
| } | ||||||
| return CompletableFuture.completedFuture(null); | ||||||
| } | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of doing this is to show how exactly the token can be used to access any resources
(We picked Graph because Graph's User.Read is accessible to every accounts).
This change would encapsulate that.
I'd suggest we have an extra page (fragment) for Graph SDK, and you're free to bring in all the best practices with the Graph SDK in that one.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all they need to access MSGraph, and Graph SDK already wraps around the authentication part, I'd say we probably won't even need MSAL in that page
or you could have a demo of both - with, and without MSAL like what you did here
cc @hamiltonha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Graph SDK does not "do" authentication - it relies on an auth provider. It can use the provider from the Azure Identity SDK, but that SDK isn't supported in Android. So, I wrote a custom provider that wraps the token you guys already get from MSAL.
My goal here was not to undo any of the token acquisition work you've already done, just to remove the HTTP calls to Graph (which we do not want to encourage). cc @baywet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpdome I think there are multiple conflicting goals here:
We, as Microsoft, don't want to encourage people to call Microsoft Graph with a native client. Of course they technically can do it, but they shouldn't as they as loosing a lot of value from the different handlers to the types and the fluent APIs. Not using the SDK to call Microsoft Graph makes their applications less resilient and is not what is recommended.
Now, I understand you also want to showcase calling an API using the native HTTP client, this is fine, just pick a different API that doesn't have an SDK, or send the request to localhost with a mock.
I hope that makes sense and we can merge this PR in? We're on the identity call tomorrow and it'd be great if things were aligned.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, what about having both options in the code, but comment out the manual part?
We can explicitly call out something along the line of "If you're going to use MSGraph in your app, Please use the SDK. The manual way is kept here - in case you're trying to call other APIs"
We don't want to mock the request - because we still want the customer to 'play with the real thing' - we want to let them know that if they want to do it manually (if you don't have other options), here is how.
This sample app is supposed to be a playground after all, and MSGraph is the only SDK that are available to everyone by default.