Repository navigation
Sumit/modify day2 data - #31
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Sumit Sengupta (sumitsengupta)
October 7, 2026 19:48
View session
Sumit Sengupta (sumitsengupta)
left a comment
Sumit Sengupta (sumitsengupta)
left a comment
Contributor
Author
There was a problem hiding this comment.
None
There was a problem hiding this comment.
🟡 Changes recommended
The removed identity setup breaks Lab 06, and several migration, access-control, and documentation instructions are incorrect.
5 open findings
What changed in this PR
Streamlines the data-modernization lab by removing Challenges 5–6 and refining migration instructions.
Changes:
- Expands assessment and SQL MI connection guidance.
- Clarifies DMS backup and online migration steps.
- Removes private-endpoint and application-readiness challenges.
| File | Description |
|---|---|
labs/day-2/05-modernize-data/README.md |
Revises and shortens the Lab 05 workflow. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| #### Validate firewall access to SQL MI before begining. | ||
|
|
||
| Validate from the portal, that the NSG for the VNet that Azure SQL Managed Instance is allowing inbount access to port 3342. If not, add an inbound rule for port 3342. From the overview page of SQL MI, click on virtual network/subnet. On the subnet page, find the Network Security Group name. Pull up that NSG by name and add an imbound port rule like this: |
| ALTER ROLE db_datareader ADD MEMBER [caldova_retail_app]; | ||
| ALTER ROLE db_datawriter ADD MEMBER [caldova_retail_app]; | ||
| ``` | ||
| Wait till all transaction logs have all been restored and no files left ( as seen in azure storage ) to restore. |
|  | ||
|
|
||
| Once the storage account is created, you will need to grant to your current Azure user the permission to manage Blob containers. Do this via IAM. Assign the *Storage Blob Data Owner* role to your own Entra ID. | ||
| Once the storage account is created, you will need to grant to your current Azure user the permission to manage Blob containers. Do this via IAM. Assign the *Storage Blob Data Owner* (or Contributor) role to your own Entra ID. |
| 4. What evidence is required before declaring the migration successful? | ||
| 5. What would change for a production migration with minimal downtime? | ||
| 6. Which steps should be automated for repeatable delivery? | ||
| #### Congratulations - you have migrated to Azure SQL |
| 4. Connect to the target SQL MI using SSMS. Select the right option in SSMS when loging in. To find out the Entra ID to use for login, navigate from the portal to the deployed Azure SQL Managed Instance and go to Microsoft Entra ID on the left under settings. In this lab, this Entra ID is same as your Azure login - also shared under <b>"Resources"</b> section on the top. | ||
|
|
||
|  | ||
| 7. Connect to the target SQL MI using SSMS. Notice that there are no databaes there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take out lab5 and lab6 of data mod - as these can either be not implemented or be tested in skillable environment.