Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[829] Add new REST API for data generation. #986

Closed
wants to merge 12 commits into from
Prev Previous commit
Next Next commit
minimize app.js
  • Loading branch information
bsherwin committed Jan 6, 2025
commit 37312ed444e3139657a8135c242025d89048ea79
Binary file modified e2e_samples/parking_sensors/data/data-simulator.zip
Copy link
Contributor

@elenaterenzi elenaterenzi Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the zip file contains the actual web app code, and like this (as it's a zip) we cannot review its contents nor do source control. Plus we might need to change the contents in the future, so we need to host the web app code "in clear text" on the repo and via deploy_infrastructure.sh script compile it and ship it to appservice. Basically, we need a step prior to ARM deployment where we compile and create the zip file which is then shipped to appservice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, can we leave this as a zip, until we decide how the data-simulator is going to be source controlled in the overall solution? Making this change will involve updating the prerequisites for the user to have nodejs and a command-line zip installed on their machine (and verify in devcontainer) in order do this during deployment time.

Binary file not shown.
Loading