-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[829] Add new REST API for data generation. #986
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
48fe0a4
Documentation updates
bsherwin e8822f6
Changes to move to fictional REST endpoint.
bsherwin 20b2d88
Merge branch 'e2e/databricks/parking-sensors-V1' into brsherwi/829
bsherwin a9922e1
Merge branch 'e2e/databricks/parking-sensors-V1' into brsherwi/829
bsherwin 5b2d02f
Replace echo with log in deploy script
bsherwin fadb6c0
Update API versions in appservice.bicep
bsherwin 769c463
Move separate bash to deploy_infrastructure.sh
bsherwin d7748f0
using quotes bc dashes and using log
bsherwin 156d455
fix deploy to multiple env
bsherwin 37312ed
minimize app.js
bsherwin 8d264e0
Update broken-hyperlinks-check.yml
bsherwin b20b005
Merge branch 'e2e/databricks/parking-sensors-V1' into brsherwi/829
bsherwin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
minimize app.js
- Loading branch information
commit 37312ed444e3139657a8135c242025d89048ea79
There are no files selected for viewing
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the zip file contains the actual web app code, and like this (as it's a zip) we cannot review its contents nor do source control. Plus we might need to change the contents in the future, so we need to host the web app code "in clear text" on the repo and via
deploy_infrastructure.sh
script compile it and ship it to appservice. Basically, we need a step prior to ARM deployment where we compile and create the zip file which is then shipped to appservice.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, can we leave this as a zip, until we decide how the data-simulator is going to be source controlled in the overall solution? Making this change will involve updating the prerequisites for the user to have nodejs and a command-line zip installed on their machine (and verify in devcontainer) in order do this during deployment time.