-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Databricks E2E] Refactor code and log messages to stderr
#962
[Databricks E2E] Refactor code and log messages to stderr
#962
Conversation
stderr
stderr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool log function. I left just one comment while loading the env variables in the bash file., approving so it will not block you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just think we should delete the trace instead of commenting not to have inactive code checked in - but maybe there is a reason why you want to keep it commented? Other than that - GREAT job! I'm thrilled that we have this function now!
e2e_samples/parking_sensors/scripts/deploy_azdo_service_connections_github.sh
Outdated
Show resolved
Hide resolved
aba8fa9
into
e2e/databricks/parking-sensors-V1
Type of PR
Purpose
stderr
. From now on we should avoid usingecho
to send (human-readable) messages to console.print_style
)set -o xtrace
that are printing tokens to console.Dockerfile
to include a bicep upgrade to remove warningsDoes this introduce a breaking change? If yes, details on what can break
No breaking change, but moving forward we should use this new function to log messages to console
Author pre-publish checklist
Validation steps
Issues Closed or Referenced