Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archive synapse samples, update readme to remove "Modern Data Warehouse" terminology, replace with "Medallion" #757

Merged
merged 11 commits into from
Nov 6, 2024
Merged

Archive synapse samples, update readme to remove "Modern Data Warehouse" terminology, replace with "Medallion" #757

merged 11 commits into from
Nov 6, 2024

Conversation

devlace
Copy link
Contributor

@devlace devlace commented Oct 11, 2024

Type of PR

  • Documentation changes

Purpose

  • Updates the main readme to remove references to "Modern Data Warehouse" in preparation for repo rename.
  • Tidied up README
  • Updated diagram to drawio
  • Archived Synapse samples

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • ...

Issues Closed or Referenced

  • Closes #issue_number
  • References #issue_number

@devlace devlace marked this pull request as ready for review October 11, 2024 04:24
@devlace devlace changed the title Archive synapse samples, update readme to remove Modern Data Warehouse Archive synapse samples, update readme to remove "Modern Data Warehouse" terminology, replace with "Medallion" Oct 14, 2024
promisinganuj
promisinganuj reviewed Oct 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@promisinganuj
Copy link
Contributor

Can we also introduce the concept of "utilities" in this PR? We can copy a script from this location, if required:
https://github.com/Azure-Samples/modern-data-warehouse-dataops/tree/main/single_tech_samples/fabric/fabric_ci_cd#other-useful-utility-scripts

@devlace devlace self-assigned this Oct 28, 2024
@devlace devlace added the e2e: fabric Related with E2E Fabric Sample label Oct 29, 2024
@devlace devlace linked an issue Oct 29, 2024 that may be closed by this pull request
Replace Modern Data Warehouse Terminology with Medallion #767
Closed
@devlace devlace removed the e2e: fabric Related with E2E Fabric Sample label Oct 29, 2024
@devlace
Copy link
Contributor Author

devlace commented Oct 30, 2024

Added the utilities folder but did not move your script. We can do that as a separate PR.

bsherwin
bsherwin approved these changes Nov 1, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
promisinganuj
promisinganuj reviewed Nov 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
promisinganuj
promisinganuj reviewed Nov 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
promisinganuj
promisinganuj reviewed Nov 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
promisinganuj
promisinganuj reviewed Nov 4, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@devlace devlace merged commit 548d504 into main Nov 6, 2024
4 checks passed
@devlace devlace deleted the lace/update-main-readme branch November 6, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@promisinganuj promisinganuj promisinganuj left review comments

@bsherwin bsherwin bsherwin approved these changes

Assignees

@devlace devlace

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Modern Data Warehouse Terminology with Medallion
3 participants
@devlace @promisinganuj @bsherwin