-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Anuj] Adding Fabric CI/CD sample #695
Conversation
…strap Initial bootstrap changes
Co-authored-by: sreedhar-guda <sreedharab@gmail.com>
Co-authored-by: sreedhar-guda <sreedharab@gmail.com>
…e-pipelines Adding CD release code and documentation
…strap [ANUJ] Bootstrap fixed and documentation update
…strap [Fabric CI/CD] Adding architecture diagram
[Fabric CI/CD] - Adding timeout to CD and final documentation changes
added code to update admin privs on workspaces and deployment pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the bootstrap for new changes and it worked as expected.
…ity-functionality Adding new environment vairable for adding existing capacity name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, but added some suggestion to the CD part that should be changed before the merge. Also, there are some clean-up included - we should make a small note on the PR goals as some of the files are not related with the current scope of the PR. Other than that it looks good to me! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank YOU!
Type of PR
Purpose
Does this introduce a breaking change? If yes, details on what can break
Author pre-publish checklist
Validation steps
Issues Closed or Referenced