-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial feature-engineering-on-fabric single-tech sample check-in #652
feat: Initial feature-engineering-on-fabric single-tech sample check-in #652
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few initial comments (more to come).
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
Apply current suggestions from code review by Anuj on Nov. 13th Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
...ch_samples/fabric/feature_engineering_on_fabric/src/notebooks/data_catalog_and_lineage.ipynb
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/src/notebooks/data_ingestion.ipynb
Outdated
Show resolved
Hide resolved
...le_tech_samples/fabric/feature_engineering_on_fabric/src/notebooks/data_transformation.ipynb
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/src/notebooks/EDA.ipynb
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/images/fs_architecture.png
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
single_tech_samples/fabric/feature_engineering_on_fabric/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good and a very well written README with lots of great screenshots. There is one minor addition / comment on explicitly setting client_secret, but otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Type of PR
Purpose
BTW,
Does this introduce a breaking change? If yes, details on what can break
NO
Author pre-publish checklist
Validation steps
Issues Closed or Referenced
N/A