Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial feature-engineering-on-fabric single-tech sample check-in #652

Merged
merged 27 commits into from
Nov 17, 2023

Conversation

thurstonchen
Copy link
Contributor

@thurstonchen thurstonchen commented Nov 9, 2023

Type of PR

  • Documentation changes
  • Code changes

Purpose

  • Add feature-engineering-on-fabric single tech sample to path /single_tech_samples/fabric/feature_engineering_on_fabric.

BTW,

  • since Github markdown doesn't support the image resize syntax that we used in Azure DevOps Git repo, we'll resize/crop relevant screenshots and update the README later today.
  • we do not check in those large source data files, instead we put them to another Github repo for now.

Does this introduce a breaking change? If yes, details on what can break

NO

Author pre-publish checklist

  • Tested relevant Fabric notebooks in new Fabric workspace
  • Fixed README markdown lint issue with the help of VS Code extension markdownlint
  • Fixed README typos with the help of VS Code extension LTeX

Validation steps

  • Import notebooks to Fabric workspace
  • Create a new lakehouse and add the new created lakehouse to notebooks (details please refer to README)
  • Create a new environment by importing given config yaml files and set it as default Spark pool environment
  • Prepare source data files (option 1)
  • Create Fabric data pipeline (option 1) following steps described in README
  • Run the data pipeline

Issues Closed or Referenced

N/A

Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few initial comments (more to come).

Apply current suggestions from code review by Anuj on Nov. 13th

Co-authored-by: Anuj Parashar <promisinganuj@gmail.com>
@promisinganuj promisinganuj marked this pull request as ready for review November 16, 2023 02:00
Copy link
Contributor

@devlace devlace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good and a very well written README with lots of great screenshots. There is one minor addition / comment on explicitly setting client_secret, but otherwise LGTM!

Copy link
Contributor

@promisinganuj promisinganuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thurstonchen thurstonchen merged commit c45d186 into main Nov 17, 2023
3 of 4 checks passed
@promisinganuj promisinganuj deleted the feat/single-tech/feature_engineering_on_fabric branch March 26, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants