Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream Analytics CI/CD Yaml file for the Tech Sample #549

Merged
merged 16 commits into from
Oct 27, 2022
Merged

Stream Analytics CI/CD Yaml file for the Tech Sample #549

merged 16 commits into from
Oct 27, 2022

Conversation

snorris31
Copy link
Contributor

@snorris31 snorris31 commented Oct 17, 2022 •
edited
Loading

Type of PR

  • Documentation changes
  • CI-CD changes

Purpose

  • This fixes the error when testing the job locally (missing jobconfig and a few other updates required)
  • This adds a generalized CI/CD yaml file for the Stream Analytics sample. It currently only works for ADO Pipelines, so in the future, it would be good to generalize this more!

Does this introduce a breaking change? If yes, details on what can break

No breaking changes.

Author pre-publish checklist

  • Made corresponding changes to the documentation

Validation steps

  • ...

Issues Closed or Referenced

  • Closes #issue_number
  • References #issue_number

@ghost
Copy link

ghost commented Oct 17, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@jmostella jmostella self-requested a review October 17, 2022 00:49
@snorris31 snorris31 marked this pull request as ready for review October 18, 2022 04:38
@snorris31 snorris31 requested a review from devlace October 18, 2022 04:39
@snorris31 snorris31 requested a review from jmostella October 22, 2022 03:18
jmostella
jmostella approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@jmostella jmostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this.

@jmostella jmostella self-assigned this Oct 27, 2022
@jmostella jmostella merged commit d3505bf into main Oct 27, 2022
@devlace devlace deleted the sanorris/cicdstreamanalytics branch October 9, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmostella jmostella jmostella approved these changes

@devlace devlace Awaiting requested review from devlace

Assignees

@jmostella jmostella

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snorris31 @jmostella