Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed flaky e2e test #355

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

jmostella
Copy link
Contributor

  • e2e.ts refactored and adjust expected latency
  • README.md moved "Add device" to "Deploy" step

Type of PR

Bug fix

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose

The e2e test has had intermittent failures running locally.

Does this introduce a breaking change? If yes, details on what can break

no

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

  • ...

Issues Closed or Referenced

  • Closes #issue_number
  • References #issue_number

@jmostella jmostella requested a review from devlace May 27, 2021 02:59
* e2e.ts refactored and adjust expected latency
* README.md moved "Add device" to "Deploy" step
Copy link
Contributor

@devlace devlace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmostella jmostella merged commit ba9bcdf into Azure-Samples:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants