Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep IaC templates with Streaming Analytics Job Sample (#94) #321

Merged
merged 2 commits into from
May 21, 2021

Conversation

jmostella
Copy link
Contributor

* README.md  Describes how to run the project in Azure and perform functional, unit, and e2e test using an online simulator.
  Added section on "Key Concepts"
* .gitignore Added
* containers.bicep Creates blob storaage container as data sink
* iothubs.bicep Creates IoT Hub
* streamingjobs.bicep Creates ASA job
* main.bicep Creates all Azure resources necessary for sample
* streamanalytics-tech-sample.asaql Sample query for filtering temperature > 27
* test/temperature_equal_to_27_degrees.json Test case data
* temperature_greater_than_27_degrees_expected.json Test case data
* temperature_greater_than_27_degrees.json Test case data
* temperature_less_than_27_degrees.json Test case data
* testConfig.json Added

Type of PR

  • Documentation changes
  • Code changes
  • Test changes
  • CI-CD changes
  • GitHub Template changes

Purpose

Adds Azure Streaming Analytics Single Tech Sample

Does this introduce a breaking change? If yes, details on what can break

Author pre-publish checklist

  • Added test to prove my fix is effective or new feature works
  • No PII in logs
  • Made corresponding changes to the documentation

Validation steps

Follow markdown documentation

Issues Closed or Referenced

@jmostella jmostella requested a review from devlace May 7, 2021 08:40
@jmostella jmostella self-assigned this May 7, 2021
Copy link
Contributor

@devlace devlace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments -- mostly around the setup scripts. Not for this PR, but I think this would benefit a .devcontainer --probably something for the future. Other than that, its looking good :)

single_tech_samples/streamanalytics/README.md Outdated Show resolved Hide resolved
single_tech_samples/streamanalytics/README.md Show resolved Hide resolved
single_tech_samples/streamanalytics/README.md Outdated Show resolved Hide resolved
@jmostella jmostella force-pushed the single-tech/streamanalytics branch from e42a733 to 5fe7543 Compare May 12, 2021 17:34
@jmostella jmostella requested a review from devlace May 12, 2021 17:41
jmostella added 2 commits May 17, 2021 18:46
* README.md  Describes how to run the project in Azure and perform functional, unit, and e2e test using an online simulator.
  Added section on "Key Concepts"
* .gitignore Added
* containers.bicep Creates blob storaage container as data sink
* iothubs.bicep Creates IoT Hub
* streamingjobs.bicep Creates ASA job
* main.bicep Creates all Azure resources necessary for sample
* streamanalytics-tech-sample.asaql Sample query for filtering temperature > 27
* test/temperature_equal_to_27_degrees.json Test case data
* temperature_greater_than_27_degrees_expected.json Test case data
* temperature_greater_than_27_degrees.json Test case data
* temperature_less_than_27_degrees.json Test case data
* testConfig.json Added
* main.bicep removed default values.
* README.md Complete env variable usage.
@jmostella jmostella force-pushed the single-tech/streamanalytics branch from 5fe7543 to 67bf368 Compare May 17, 2021 09:48
@devlace devlace merged commit abd95bc into master May 21, 2021
@devlace devlace deleted the single-tech/streamanalytics branch March 29, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants