pre requisite check

e2e_samples/fabric_dataops_sample/scripts/verify_prerequisites.sh

@@ -1,39 +1,35 @@
 #!/bin/bash
+set -o errexit
+set -o pipefail
+set -o nounset
 
 echo "[Info] ############ STARTING PRE REQUISITE CHECK ############"
-# Path to the .env file (default is "../.env")
 ENV_FILE=${1:-"../.env"}
 
-# -------------------------------
-# Function to check if Python is installed and its version
+# Function to check if Python 3 is installed and meets the version requirement
 check_python_version() {
   if ! command -v python3 &>/dev/null; then
     echo "[Error] Python is not installed or not available in PATH."
     exit 1
   fi
 
-  # Get the Python interpreter being used
   PYTHON_INTERPRETER=$(which python3)
   echo "[Info] Using Python interpreter: $PYTHON_INTERPRETER"
 
-  # Get the Python version
   PYTHON_VERSION=$(python3 --version 2>&1)
   echo "[Info] $PYTHON_VERSION found."
 
-  # Get the Python version components
   PYTHON_VERSION_MAJOR=$(python3 -c "import sys; print(sys.version_info.major)")
   PYTHON_VERSION_MINOR=$(python3 -c "import sys; print(sys.version_info.minor)")
 
-  # Check if Python version is at least 3.9
   if [[ "$PYTHON_VERSION_MAJOR" -lt 3 || ("$PYTHON_VERSION_MAJOR" -eq 3 && "$PYTHON_VERSION_MINOR" -lt 9) ]]; then
     echo "[Error] Python version ${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR} found. Python 3.9 or higher is required."
     exit 1
   fi
   echo "[Info] Python version ${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR} is installed and meets the requirement (>= 3.9)."
 }
 
-# -------------------------------
-# Function to check if Python libraries are installed
+# Function to check if required Python libraries are installed
 check_python_libraries() {
   local libraries=("requests")
   for library in "${libraries[@]}"; do
@@ -45,19 +41,24 @@ check_python_libraries() {
   done
 }
 
-# -------------------------------
-# Function to check if Terraform is installed
+# Function to check if Terraform is installed and meets version requirements
 check_terraform() {
   if ! command -v terraform &>/dev/null; then
     echo "[Error] Terraform is not installed or not available in PATH."
     exit 1
   fi
-  TERRAFORM_VERSION=$(terraform version | head -n1 | grep -oP 'v\K[0-9]+\.[0-9]+\.[0-9]+')
+
+  TERRAFORM_VERSION=$(terraform version | grep -oP '^Terraform\s+v\K[0-9]+\.[0-9]+\.[0-9]+')
+
+  if [[ $? -ne 0 || -z "$TERRAFORM_VERSION" ]]; then
+    echo "[Error] Failed to retrieve Terraform version."
+    exit 1
+  fi
+
   echo "[Info] Terraform version $TERRAFORM_VERSION is installed."
 }
 
-# -------------------------------
-# Function to check if Azure CLI is installed
+# Function to check if Azure CLI is installed and meets version requirements
 check_azure_cli() {
   if ! command -v az &>/dev/null; then
     echo "[Error] Azure CLI is not installed or not available in PATH."
@@ -67,8 +68,7 @@ check_azure_cli() {
   echo "[Info] Azure CLI version $AZURE_CLI_VERSION is installed."
 }
 
-# -------------------------------
-# Function to check if 'jq' is installed
+# Function to check if jq (command-line JSON processor) is installed
 check_jq() {
   if ! command -v jq &>/dev/null; then
     echo "[Error] 'jq' is not installed or not available in PATH. You can install 'jq' using: sudo apt-get install jq (for Ubuntu)."
@@ -77,64 +77,41 @@ check_jq() {
   echo "[Info] 'jq' is installed."
 }
 
-# Check if .env file exists
-if [[ ! -f "$ENV_FILE" ]]; then
-  echo "[Error] .env file not found at $ENV_FILE"
-  exit 1
-fi
-
-# Extract variable names from the .env file (ignore comments and blank lines)
-REQUIRED_ENV_VARS=$(grep -oP '^\s*export\s+\K[A-Z_][A-Z0-9_]*' "$ENV_FILE")
-
-if [[ -z "$REQUIRED_ENV_VARS" ]]; then
-  echo "[Error] No valid environment variable exports found in $ENV_FILE."
-  exit 1
-fi
-
-# List of compulsory variables that must have non-empty values
-COMPULSORY_VARS=("TENANT_ID" "SUBSCRIPTION_ID" "RESOURCE_GROUP_NAME" "BASE_NAME" "FABRIC_WORKSPACE_ADMIN_SG_NAME" "FABRIC_CAPACITY_ADMINS")
-
-# Function to check environment variables
+# Function to check if required environment variables are set and non-empty
 check_env_vars() {
-  local missing_compulsory_vars=() # Array to store missing or empty compulsory variables
+  if [[ ! -f "$ENV_FILE" ]]; then
+    echo "[Error] .env file not found at $ENV_FILE"
+    exit 1
+  fi
+
+  REQUIRED_ENV_VARS=$(grep -oP '^\s*export\s+\K[A-Z_][A-Z0-9_]*' "$ENV_FILE")
+  COMPULSORY_VARS=("TENANT_ID" "SUBSCRIPTION_ID" "RESOURCE_GROUP_NAME" "BASE_NAME" "FABRIC_WORKSPACE_ADMIN_SG_NAME" "FABRIC_CAPACITY_ADMINS")
+  local missing_compulsory_vars=()
 
-  # Check compulsory variables
   for var in "${COMPULSORY_VARS[@]}"; do
     if [ -z "${!var-}" ]; then
       missing_compulsory_vars+=("$var")
     fi
   done
 
-  # Handle missing compulsory variables
   if [ ${#missing_compulsory_vars[@]} -gt 0 ]; then
     echo "[Error] The following compulsory environment variables are missing or empty:"
     for var in "${missing_compulsory_vars[@]}"; do
       echo "  - $var"
     done
-    echo "[Info] Please set the above variables in your environment or source the .env file:"
-    echo "  source $ENV_FILE"
+    echo "Please set the above variables or source the .env file."
     exit 1
   fi
 
   echo "[Info] All compulsory environment variables are set and non-empty."
 }
 
-# Example usage
-export ENV_FILE="./.env"
-check_env_vars
-
-# -------------------------------
-# Run checks
-echo "[Info] Checking system requirements..."
+# Main flow
 check_python_version
 check_python_libraries
 check_terraform
 check_azure_cli
 check_jq
-
-echo "[Info] Checking environment variables..."
 check_env_vars
 
-# All checks passed
-echo "[Info] All system requirements and environment variables are satisfied."
 echo "[Info] ############ PRE REQUISITE CHECK FINISHED ############"