-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ST] Add sample port for H745I-DISCO #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hihigupt ! I'll give this a try as soon as I have some free time.
* unexpected behaviour, such as calls to malloc(). */ | ||
int iMainRand32( void ) | ||
{ | ||
static UBaseType_t uxlNextRand; /*_RB_ Not seeded. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to follow this link ... Could please provide the link to specific line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - it was the already implemented secure random function instead of implementing a pseudo-random function - likely wrong paste.
@@ -0,0 +1,71 @@ | |||
/* USER CODE BEGIN Header */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see inconsistent usage of main.h (e.g. in NXP it is checked in but not used).
Should we get the common APIs required by the sample defined here then include in the sample c file (e.g. the Error_Handler, Random and Time PAL functions).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ST projects are created using CubeMX and that generates main.h, just to keep it similar to ST experience I kept it same.
Regarding NXP I am not seeing any file name main.h in main branch of this repo (https://github.com/Azure-Samples/iot-middleware-freertos-samples/tree/main/demos/projects/NXP/mimxrt1060), am I missing something here?
main.c is more attached to platform and wanted to make sure it remain same to how that platform provides its sample to boot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, OK - a prior version or something happened to my fork - I have main.h in NXP but wasn't referenced.
demos/projects/ST/stm32h745i_discovery/cm7/st_code/lwip/system/arch/sys_arch.h
Show resolved
Hide resolved
297e045
to
6ae878b
Compare
6ae878b
to
f10ad61
Compare
No description provided.