Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnp sample #28

Merged
merged 14 commits into from
Jul 9, 2021
Merged

pnp sample #28

merged 14 commits into from
Jul 9, 2021

Conversation

danewalton-msft
Copy link
Collaborator

No description provided.

@danewalton-msft danewalton-msft requested a review from hihigupt June 17, 2021 15:55
hihigupt
hihigupt reviewed Jun 17, 2021
View reviewed changes
demos/CMakeLists.txt Outdated Show resolved Hide resolved
hihigupt
hihigupt reviewed Jul 7, 2021
View reviewed changes
demos/projects/ST/b-l475e-iot01a/CMakeLists.txt

# Add PnP Sample
add_executable(${PROJECT_NAME}-pnp ${PROJECT_SOURCES})
target_include_directories(${PROJECT_NAME}-pnp PUBLIC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently in gcc_flags we set the map file to be output.map, and now we have two target generated. This will cause the later target to override previous map file.

jspaith
jspaith reviewed Jul 8, 2021
View reviewed changes
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot/sample_azure_iot.c Outdated Show resolved Hide resolved
jspaith
jspaith requested changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@jspaith jspaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking request mostly because I'm not I think we need to look again at the "Are we sure this is eAzureIoTHubClientPropertyWritable comment down below since that's impact functionality potentially.

demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Outdated Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Show resolved Hide resolved
demos/sample_azure_iot_pnp/sample_azure_iot_pnp.c Show resolved Hide resolved
@danewalton-msft
Copy link
Collaborator Author

image

Just to dot I's and cross T's. As the code is currently in this PR, it passed the PnP certification tests

@danewalton-msft danewalton-msft merged commit ddb3c69 into main Jul 9, 2021
@danewalton-msft danewalton-msft deleted the dawalton/pnp_v2 branch July 9, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hihigupt hihigupt hihigupt approved these changes

@jspaith jspaith jspaith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danewalton-msft @hihigupt @jspaith