Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update API versions and add Bicep #8

Conversation

mumian
Copy link
Contributor

@mumian mumian commented Dec 7, 2022

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@patelchandni
Copy link
Collaborator

@mumian What are the changes in azuredeploy.json? It is really hard to compared. Please clean the spaces/tab added/removed if possible

@patelchandni patelchandni merged commit cd562e1 into Azure-Samples:main Dec 13, 2022
@mumian mumian deleted the 1207-function-app-private-endpoints-storage-private-endpoints branch December 14, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants