Fix Dockerfile for Azure Container Registry builds #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As commented in #3 by @horihiro:
This commit moves the Dockerfile to the root of the repository. This
file was updated to reflect this move, removed duplicate work from
COPY
commands and ensure the same file work consistently for bothlocal builds and for Azure Container Registry builds.
Fixes #3
Also addresses MicrosoftDocs/azure-docs#101118
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Get the code
For ACR builds, follow the steps as described on https://learn.microsoft.com/en-us/azure/container-apps/deploy-visual-studio-code#create-the-container-registry-and-docker-image up to the section and following sections up to (and including) "Create the container app and deploy the Docker image".
What to Check
For local builds, ensure
docker run...
executed previously runs successfully and outputs the following:For ACR, ensure that the CApps creation was successful.
For both: also ensure the application is working by using curl:
Replace
localhost
with the IP of the host exposed by ACAOther Information