Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include auth login fix for github codespaces users #1856

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

GiuseppeGalilei
Copy link
Contributor

Purpose

Proposes an alternative command for azure auth login that solves issues encountered by GitHub Codespaces users.
Closes #1855

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[x] Yes
[ ] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 6, 2024

Check Broken Paths

We have automatically detected the following broken relative paths in your files.
Review and fix the paths to resolve this issue.

Check the file paths and associated broken paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
README.md
#LinkLine Number
1/docs/gpt4vision.md44
samples/chat/README.md
#LinkLine Number
1/docs/gpt4vision.md60

README.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 6, 2024

Check Broken Paths

We have automatically detected the following broken relative paths in your files.
Review and fix the paths to resolve this issue.

Check the file paths and associated broken paths inside them. For more details, check our Contributing Guide.

File Full Path Issues
README.md
#LinkLine Number
1/docs/gpt4vision.md44
samples/chat/README.md
#LinkLine Number
1/docs/gpt4vision.md60

@pamelafox
Copy link
Collaborator

Technically azd is supposed to autodetect when to use device code, but I just got another report of it not working, so I think we should go ahead and document.

@pamelafox pamelafox merged commit fe229cc into Azure-Samples:main Sep 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Azd auth login" fails in Github Codespaces
2 participants