-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add low cost browser text to speech output using WebSpeechAPI #1671
Conversation
This PR adds the optional feature to enable the built into browsers text to speech optional feature by setting the boolean.
Thank you! Code looks good from a first glance, I'll check out the branch myself locally and see if I notice anything while using it. |
I tried to make the naming match your |
Weird, I did run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great code change! Everything works well, looks good, and is cleanly implemented. I tried it out locally and deployed (https://app-backend-ixehwdxj5j4oe.azurewebsites.net/), all seems well.
Purpose
This PR adds the optional feature to enable the built into browsers text to speech optional feature by setting the
USE_SPEECH_OUTPUT_BROWSER
boolean.Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.