Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement chat protocal #299

Merged
merged 9 commits into from
Apr 15, 2024
Merged

implement chat protocal #299

merged 9 commits into from
Apr 15, 2024

Conversation

LittleLittleCloud
Copy link
Collaborator

Purpose

  • ...

This PR implements chat protocal (non-streaming) part.

Does this introduce a breaking change?

[ ] Yes
[x] No

fix #254

Link to chat protocal: https://github.com/Azure-Samples/ai-chat-app-protocol

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@JakeRadMSFT JakeRadMSFT mentioned this pull request Mar 27, 2024
Open
IEvangelist
IEvangelist previously approved these changes Apr 10, 2024
View reviewed changes
app/backend/Extensions/KeyVaultConfigurationBuilderExtensions.cs Outdated Show resolved Hide resolved
app/shared/Shared/Models/ChatMessage.cs Outdated Show resolved Hide resolved
app/shared/Shared/Models/ChatRequest.cs Outdated Show resolved Hide resolved
app/shared/Shared/Models/ChatRequest.cs Outdated Show resolved Hide resolved
app/shared/Shared/Models/ChatRequest.cs Outdated Show resolved Hide resolved
app/shared/Shared/Models/RequestOverrides.cs Show resolved Hide resolved
app/shared/Shared/Models/ResponseChoice.cs Outdated Show resolved Hide resolved
@LittleLittleCloud LittleLittleCloud merged commit e193da4 into main Apr 15, 2024
2 checks passed
@LittleLittleCloud LittleLittleCloud deleted the u/xiaoyun/chatProtocal branch April 15, 2024 18:49
mohamedsaif added a commit to mohamedsaif/azure-search-openai-demo-csharp that referenced this pull request May 7, 2024
@mohamedsaif
Merge pull request #1 from mohamedsaif/main
c58c108 
implement chat protocal (Azure-Samples#299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Chat protocol for backend
2 participants
@LittleLittleCloud @IEvangelist