Skip to content

Fix maven dependency issues #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbauerrfid wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix maven dependency issues #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b655f7
fix dependency versions
jbauerrfid Oct 6, 2021
a21684c
fix indentation
jbauerrfid Oct 6, 2021
8989d35
remove repository entry, use maven central
jbauerrfid Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 12 additions & 18 deletions v12/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>Azure-Storage-SDK-V10-Java</groupId>
<artifactId>QuickStart</artifactId>
<version>0.1</version>
<repositories>
<repository>
<id>commicrosoftazure-2334</id>
<name>commicrosoftazure-2334</name>
<url>https://oss.sonatype.org/content/repositories/commicrosoftazure-2334</url>
</repository>
</repositories>

<build>
<plugins>
Expand All @@ -25,7 +19,7 @@
<compilerArgument>-Xlint:unchecked</compilerArgument>
</configuration>
</plugin>

<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
Expand All @@ -34,20 +28,20 @@
<mainClass>quickstart.Quickstart</mainClass>
</configuration>
</plugin>

</plugins>
</build>

<dependencies>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-storage-common</artifactId>
<version>12.0.0</version>
</dependency>
<groupId>com.azure</groupId>
Copy link

@conniey conniey Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would be referencing the BOM (azure-sdk-bom) so that the dependencies are aligned. azure-storage-blob transitively brings in azure-storage-common so you do not need to explicitly reference this.

https://search.maven.org/artifact/com.azure/azure-sdk-bom/1.0.5/pom

<artifactId>azure-storage-common</artifactId>
<version>12.13.0</version>
</dependency>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-storage-blob</artifactId>
<version>12.0.0</version>
</dependency>
<groupId>com.azure</groupId>
<artifactId>azure-storage-blob</artifactId>
<version>12.14.0</version>
</dependency>
</dependencies>
</project>