removing unused env var, adjusting postdeploy logic to no longer await for user inpu#7
Open
removing unused env var, adjusting postdeploy logic to no longer await for user inpu#7
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the GitHub Actions workflow and documentation to remove an unused environment variable and to improve the post-deployment behavior by eliminating the non-interactive user input. Key changes include:
- Adding a new run_evals input parameter in the workflow configuration.
- Updating URLs in the README.md to reflect the new GitHub Pages location.
- Removing the unused AZURE_OPENAI_API_VERSION_O1 environment variable from the infrastructure documentation.
Reviewed Changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/azd_deploy.yml | Adds a new run_evals input and updates the RUN_EVALS environment variable assignment |
| README.md | Updates multiple hyperlinks to point to the new GitHub Pages URL |
| infra/README.md | Removes a no-longer-needed environment variable |
Files not reviewed (6)
- infra/main.json: Language not supported
- infra/resources.bicep: Language not supported
- infra/resources.json: Language not supported
- utils/azd/hooks/postdeploy.sh: Language not supported
- utils/azd/hooks/postprovision.ps1: Language not supported
- utils/azd/hooks/postprovision.sh: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ths user input at the postdeploy script did not behave interactively as intended. It waits and hangs without displaying the prompt. Due to this, removing the user input for RUN_EVALS and relying on environment variable declaration by skipping if RUN_EVALS is not set.
This pull request includes changes to the workflow configuration, documentation updates, and the removal of an unused environment variable. The most important changes are summarized below:
Workflow Configuration:
run_evalsinput parameter to the GitHub Actions workflow to control whether model evaluations are run. (.github/workflows/azd_deploy.yml) [1] [2]Documentation Updates:
README.mdto point to the new GitHub Pages URL for the AutoAuth solution accelerator. (README.md) [1] [2] [3] [4] [5]Environment Variable Removal:
AZURE_OPENAI_API_VERSION_O1environment variable from various infrastructure and utility scripts as it is no longer needed. (infra/README.md,infra/main.json,infra/resources.bicep,infra/resources.json,utils/azd/hooks/postdeploy.sh,utils/azd/hooks/postprovision.ps1,utils/azd/hooks/postprovision.sh) [1] [2] [3] [4] [5] [6] [7]# Project Enhancement Request