Skip to content

Added support for all headers #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

jhorie
Copy link

@jhorie jhorie commented Jun 13, 2025

Added support for Cache-Control, Content-Encoding, Content-Language, Content-Disposition headers.

@jhorie jhorie changed the title Added Cache-Control as a header Added support for all headers Jun 13, 2025
@brecht-vermeersch
Copy link
Member

Thanks for the PR! Just a couple remarks:

  • We try to follow the same api as the .net client.

https://learn.microsoft.com/en-us/dotnet/api/azure.storage.blobs.models.blobuploadoptions?view=azure-dotnet

https://learn.microsoft.com/en-us/dotnet/api/azure.storage.blobs.models.blobhttpheaders?view=azure-dotnet

  • This means moving the http headers into a separate class BlobHttpHeaders that we can reuse everywhere.

  • Please also add it to all the different upload methods. (single, sequential and parallel)

…lize and extend Blob HTTP headers support.
@jhorie
Copy link
Author

jhorie commented Jun 20, 2025

I am not sure how to run the tests. The changes are done.

…ded detailed Blob HTTP headers management. Enhanced tests for content encoding and additional header validations. Updated dependencies and configuration for completeness.
@jhorie
Copy link
Author

jhorie commented Jun 24, 2025

I actually managed to fix testing, I had found some time to dive into it.

…oved readability. Enhanced test case formatting for better clarity.
@brecht-vermeersch
Copy link
Member

Will do some testing this weekend

@brecht-vermeersch
Copy link
Member

Thanks for the PR. I used the code as inspiration for an improved implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants