Skip to content

chore: fix HA flake #20143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexghr merged 1 commit into from
Feb 4, 2026
+0 −33
Merged

chore: fix HA flake #20143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .test_patterns.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,9 +170,6 @@ tests:
error_regex: "✕ should attest ONLY with the correct validator keys"
owners:
- *spyros
- regex: "src/composed/ha/e2e_ha_full.test.ts"
owners:
- *alex

# yarn-project tests
- regex: "yarn-project/kv-store"
Expand Down
30 changes: 0 additions & 30 deletions yarn-project/end-to-end/src/composed/ha/e2e_ha_full.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@ describe('HA Full Setup', () => {
// We send transactions sequentially and wait for each to be mined to ensure we get distinct blocks
const blockCount = 5;
const receipts = [];
let previousBlockNumber: number | undefined;

for (let i = 0; i < blockCount; i++) {
const deployer = new ContractDeployer(StatefulTestContractArtifact, wallet);
Expand All @@ -394,12 +393,6 @@ describe('HA Full Setup', () => {

expect(receipt.blockNumber).toBeDefined();

// Verify this transaction is in a different block than the previous one
if (previousBlockNumber !== undefined) {
expect(receipt.blockNumber).toBeGreaterThan(previousBlockNumber);
}

previousBlockNumber = receipt.blockNumber;
receipts.push(receipt);
logger.info(`Block ${i + 1}/${blockCount} created: ${receipt.blockNumber}`);
}
Expand All @@ -410,30 +403,7 @@ describe('HA Full Setup', () => {
expect(uniqueBlockNumbers.size).toBe(blockCount);
logger.info(`Created ${uniqueBlockNumbers.size} distinct blocks: ${Array.from(uniqueBlockNumbers).join(', ')}`);

// Verify work distribution across nodes
const nodeParticipation = new Map<string, number>();
const quorum = Math.floor((COMMITTEE_SIZE * 2) / 3) + 1;

for (const receipt of receipts) {
const [block] = await aztecNode.getCheckpointedBlocks(receipt.blockNumber!, 1);
if (!block) {
throw new Error(`Block ${receipt.blockNumber} not found`);
}
const slotNumber = BigInt(block.block.header.globalVariables.slotNumber);

const duties = await getValidatorDuties(mainPool, slotNumber);

// Track which nodes handled duties
for (const duty of duties) {
const count = nodeParticipation.get(duty.nodeId) || 0;
nodeParticipation.set(duty.nodeId, count + 1);
}
}

// Verify multiple nodes participated
logger.info(`Node participation: ${JSON.stringify(Array.from(nodeParticipation.entries()))}`);
expect(nodeParticipation.size).toBeGreaterThan(1);

// Verify no double-signing occurred across all blocks
for (const receipt of receipts) {
const [block] = await aztecNode.getCheckpointedBlocks(receipt.blockNumber!, 1);
Expand Down
Loading