Skip to content

Conversation

@mverzilli
Copy link
Contributor

@mverzilli mverzilli commented Feb 3, 2026

Modernizes the kv-store test harness to use Vitest+WebdriverIO to for IndexedDB tests... and some leaks that were causing this not to work on CI envs:

Leaky store management in tests: https://github.com/AztecProtocol/aztec-packages/pull/20127/changes#diff-967a973ac623e1daae8f3f51eaecee5209f80137dfce63c754a434f6d2fa74c9L11

Potential dangling queue resources when disposing stores: https://github.com/AztecProtocol/aztec-packages/pull/20127/changes#diff-6b0ce142eec6a47bdf684122466135c5405a67083e4aea5105e471bcad0631b3R206

@mverzilli mverzilli requested a review from Thunkar February 3, 2026 11:18
@socket-security
Copy link

socket-security bot commented Feb 3, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​vitest@​4.0.18961007999100
Addednpm/​@​vitest/​browser-playwright@​4.0.181001008698100

View full report

@socket-security
Copy link

socket-security bot commented Feb 3, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@mverzilli mverzilli added ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure ci-squash-and-merge and removed ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure labels Feb 3, 2026
@mverzilli mverzilli enabled auto-merge February 3, 2026 16:57
@AztecBot AztecBot force-pushed the martin/vitest-in-kv-store branch from 3b42347 to fb25c97 Compare February 3, 2026 17:00
@mverzilli mverzilli added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@mverzilli mverzilli enabled auto-merge February 3, 2026 19:25
@AztecBot AztecBot force-pushed the martin/vitest-in-kv-store branch from 32cbc05 to 9b13934 Compare February 3, 2026 19:29
@AztecBot AztecBot force-pushed the martin/vitest-in-kv-store branch from 9b13934 to 3b2e145 Compare February 3, 2026 19:32
@mverzilli mverzilli added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@mverzilli mverzilli added ci-full Run all master checks. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure ci-squash-and-merge and removed ci-full Run all master checks. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure labels Feb 3, 2026
@mverzilli mverzilli enabled auto-merge February 3, 2026 22:32
@AztecBot AztecBot force-pushed the martin/vitest-in-kv-store branch from 9c0cd84 to 5ba1637 Compare February 3, 2026 22:35
Modernizes the kv-store test harness to use Vitest+WebdriverIO to for IndexedDB tests
@AztecBot AztecBot force-pushed the martin/vitest-in-kv-store branch from 5ba1637 to 2a91e6f Compare February 3, 2026 22:47
@mverzilli mverzilli added this pull request to the merge queue Feb 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2026
@AztecBot
Copy link
Collaborator

AztecBot commented Feb 4, 2026

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/d6c482a6b3d2c554�d6c482a6b3d2c5548;;�): cd yarn-project/kv-store && yarn test (17s) (code: 1) (\033mverzilli\033: fix leaking stores)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants