-
Notifications
You must be signed in to change notification settings - Fork 587
refactor: use vitest for IndexedDB tests #20127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mverzilli
wants to merge
8
commits into
next
Choose a base branch
from
martin/vitest-in-kv-store
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+733
−1,058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
Thunkar
approved these changes
Feb 3, 2026
3b42347 to
fb25c97
Compare
32cbc05 to
9b13934
Compare
9b13934 to
3b2e145
Compare
9c0cd84 to
5ba1637
Compare
Modernizes the kv-store test harness to use Vitest+WebdriverIO to for IndexedDB tests
5ba1637 to
2a91e6f
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernizes the kv-store test harness to use Vitest+WebdriverIO to for IndexedDB tests... and some leaks that were causing this not to work on CI envs:
Leaky store management in tests: https://github.com/AztecProtocol/aztec-packages/pull/20127/changes#diff-967a973ac623e1daae8f3f51eaecee5209f80137dfce63c754a434f6d2fa74c9L11
Potential dangling queue resources when disposing stores: https://github.com/AztecProtocol/aztec-packages/pull/20127/changes#diff-6b0ce142eec6a47bdf684122466135c5405a67083e4aea5105e471bcad0631b3R206