Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve footer #175

Merged
merged 3 commits into from
Jun 30, 2022
Merged

improve footer #175

merged 3 commits into from
Jun 30, 2022

Conversation

mdrianislam0or1
Copy link
Contributor

Description

Improve footer styles in map view - Desktop view #171

Screenshots

fix#171

heliomar-pena
heliomar-pena requested changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@heliomar-pena heliomar-pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm please check code style, the rest looks good

src/pages/Delivery/Delivery.layout.jsx Outdated Show resolved Hide resolved
@angelik0828
Copy link
Contributor

@mdrianislam0or1

  1. The text used in the localization is not bold and is not proportionally sized.
  2. The text used in "estimated time of arrival" is not bold and should not be as large
  3. The text "contact us" should be blank and in normal type.

image

@Israel-Laguan Israel-Laguan self-requested a review June 23, 2022 13:55
@angelik0828
Copy link
Contributor

angelik0828 commented Jun 28, 2022 •
edited
Loading

@mdrianislam0or1 I want to ask if the change was made?, I didn't see any capture

@e-azocar e-azocar merged commit 9cabb61 into Azordev:dev Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelik0828 angelik0828 angelik0828 approved these changes

@Israel-Laguan Israel-Laguan Israel-Laguan approved these changes

@e-azocar e-azocar e-azocar approved these changes

@heliomar-pena heliomar-pena Awaiting requested review from heliomar-pena

Assignees

@mdrianislam0or1 mdrianislam0or1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mdrianislam0or1 @angelik0828 @Israel-Laguan @e-azocar @heliomar-pena