Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/#117 add time and date in messages #130

Merged
merged 2 commits into from
Apr 9, 2022
Merged

fix/#117 add time and date in messages #130

merged 2 commits into from
Apr 9, 2022

Conversation

arodriguezl9302
Copy link
Contributor

@arodriguezl9302 arodriguezl9302 commented Apr 7, 2022 •
edited
Loading

Description

Add time and date in messages

fixes #117

Screenshots

image

Type of change

Bug fix (non-breaking change which fixes an issue)

How to test it

  1. Go to 'http://localhost:3000/chat/1'

Checklist:

  • Add message date and time below
  • Show the time and date in a format understandable for humans, for example using: new Date(updated_at).toLocalString("es-CO")
  • Add the correct styles for time and date

@arodriguezl9302 arodriguezl9302 self-assigned this Apr 7, 2022
@arodriguezl9302 arodriguezl9302 requested review from Israel-Laguan, e-azocar and heliomar-pena and removed request for Israel-Laguan April 7, 2022 04:05
@arodriguezl9302 arodriguezl9302 changed the title fix: add time and date in messages fix/#117 add time and date in messages Apr 7, 2022
@heliomar-pena
Copy link
Collaborator

In the screenshot I'm seeing the date, but there isn't the time, for example: 8:00pm, 3:00am. Can you check please?

e-azocar
e-azocar reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@e-azocar e-azocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really good, but would be better with the message time

Israel-Laguan
Israel-Laguan reviewed Apr 7, 2022
View reviewed changes
src/styles/colors.js Outdated Show resolved Hide resolved
@arodriguezl9302
Copy link
Contributor Author

arodriguezl9302 commented Apr 8, 2022 •
edited
Loading

Done, this is how it looks after the changes

image

e-azocar
e-azocar approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@e-azocar e-azocar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, I liked how was before, but adding the message time. Something like this:
image

heliomar-pena
heliomar-pena approved these changes Apr 8, 2022
View reviewed changes
Copy link
Collaborator

@heliomar-pena heliomar-pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@arodriguezl9302
Copy link
Contributor Author

I asked @katsu08 and he told me it was another issue

@e-azocar e-azocar merged commit c578582 into dev Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Israel-Laguan Israel-Laguan Israel-Laguan approved these changes

@e-azocar e-azocar e-azocar approved these changes

@heliomar-pena heliomar-pena heliomar-pena approved these changes

Assignees

@arodriguezl9302 arodriguezl9302

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add time and date in messages
4 participants
@arodriguezl9302 @heliomar-pena @Israel-Laguan @e-azocar