Skip to content

Commit

Permalink
Remove "file_name" argument
Browse files Browse the repository at this point in the history
  • Loading branch information
Azeirah committed Nov 26, 2024
1 parent afbff4b commit b5683d7
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 9 deletions.
1 change: 0 additions & 1 deletion deployment/remarks-server/remarks_server/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import os, os.path

default_args = {
"file_name": None,
"ann_type": ["scribbles", "highlights"],
"combined_pdf": True,
"combined_md": True,
Expand Down
5 changes: 0 additions & 5 deletions remarks/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ def main():
help="Base directory for all files created (*.pdf, *.png, *.md, and/or *.svg)",
metavar="OUTPUT_DIRECTORY",
)
parser.add_argument(
"--file_name",
help="Work only on files whose original document names (visibleName) contain this string",
metavar="FILENAME_STRING",
)
parser.add_argument(
"--file_uuid",
help="Work only on files whose uuid is this string",
Expand Down
4 changes: 2 additions & 2 deletions remarks/remarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@


def run_remarks(
input_dir, output_dir, file_name=None, file_uuid=None, file_path=None, **kwargs
input_dir, output_dir, file_uuid=None, file_path=None, **kwargs
):
num_docs = sum(1 for _ in pathlib.Path(f"{input_dir}/").glob("*.metadata"))

Expand All @@ -60,7 +60,7 @@ def run_remarks(

doc_name = get_visible_name(metadata_path)

if (file_name and (file_name not in doc_name)) or not doc_name:
if not doc_name:
continue

if doc_type in supported_types:
Expand Down
2 changes: 1 addition & 1 deletion test_support.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from syrupy.extensions.single_file import SingleFileSnapshotExtension
import remarks

default_args = {"file_name": None, "ann_type": ["scribbles", "highlights"], "combined_pdf": True, "modified_pdf": False,
default_args = {"ann_type": ["scribbles", "highlights"], "combined_pdf": True, "modified_pdf": False,
"per_page_targets": [], "assume_malformed_pdfs": False}


Expand Down

0 comments on commit b5683d7

Please sign in to comment.