Port and update to MC 1.12 and the new Forge registry changes #214

maruohon · 2017-06-24T14:25:31Z

Some things to note:

I have also made white space clean-up in various places for my own sanity... not sure if you want those pulled
I have updated some deprecated method calls and done some other clean-up to get rid of all errors or warnings (at least in my IDE)
There is one commit where I changed the build.gradle file in relation to how it builds the API file, since I needed to build that myself to get it working for another mod of mine (gradle didn't seem to recognize *.zip files so I changed it into a jar, and the official API jar also doesn't include the built classes, so I was unable to just drop the API file into the libs/ dir while setting up a dev environment). So again, not sure if you want to pull that commit.

…wrapper.

Xalcon · 2017-06-24T23:31:34Z

src/main/java/baubles/common/items/ItemRing.java

 {
+	public static final Item RING = (new ItemRing()).setUnlocalizedName("Ring").setRegistryName("ring");


Items and blocks should be created in the corresponding registry events. If we need access to this item instance, we should use the @ObjectHolder annotation in order to support item substitution properly. Otherwise if a mod overrides this ring, weired bugs or even crashes might occur (since this instance is no longer the one that is registered to the item registry)

Xalcon · 2017-06-24T23:37:25Z

src/main/java/baubles/client/ClientProxy.java

-		ModelLoader.setCustomModelResourceLocation(Config.itemRing, 0, new ModelResourceLocation("baubles:Ring", "inventory"));
+
+	@SubscribeEvent
+	public static void registerItemModels(ModelRegistryEvent event) {


In my opinion, events shouldnt be part of the proxy. Might want to move this either to the mod class or even its own class.

Xalcon · 2017-06-24T23:42:14Z

src/main/java/baubles/common/items/ItemRing.java

 	@SideOnly(Side.CLIENT)
 	@Override
-	public void getSubItems(Item par1, CreativeTabs par2CreativeTab, NonNullList<ItemStack> par3NonNullList) {
-		par3NonNullList.add(new ItemStack(this,1,0));
+	public void getSubItems(CreativeTabs tab, NonNullList<ItemStack> list) {


as of Forge 14.21.0.2360 this method is no longer client only!
See http://files.minecraftforge.net/maven/net/minecraftforge/forge/1.12-14.21.0.2360/forge-1.12-14.21.0.2360-changelog.txt

I went ahead and removed all @SideOnly(Side.CLIENT) annotations, as they seemed to all be unnecessary. And as was just discussed on #minecraftforge, modders should not be using it, unless absolutely necessary. I will push that tomorrow, after I have the chance to actually test that this doesn't break on a server after all though...

…or it

Lothrazar · 2017-06-30T01:13:15Z

If this is not going to be released for a while, can devs get an API or maven or something to develop to it?

currently i just have my @optional baubles tags commented out and id just do another build when this is ready.

GirafiStudios · 2017-06-30T01:19:20Z

src/main/java/baubles/client/gui/BaublesGuiFactory.java

-	@Override
-	public void initialize(Minecraft minecraftInstance) { }
+	public BaublesGuiFactory() {
+		super(Baubles.MODID, getTitle());


You can just put getAbridgedConfigPath here, and then call the field "title" in createConfigGui. Same thing with modid really.
Example: https://github.com/squeek502/WailaHarvestability/blob/1.12.x/java/squeek/wailaharvestability/gui/config/GuiFactory.java

asiekierka · 2017-06-30T08:38:52Z

@PrinceOfAmber You can use Charset's Ivy dependency mirror for the time being, if you need to.

@maruohon Found a bug - tooltips on items do not render in the Baubles menu.

…ings.

Lothrazar · 2017-06-30T20:34:32Z

@asiekierka thanks! not sure exactly what you mean, do you have your dependences do a fallback to custom jars here? https://github.com/CharsetMC/Charset/blob/1.12/build.gradle#L55

Lothrazar · 2017-07-15T04:38:41Z

@maruohon I was testing out using baubles from this branch, and i think theres an item dup glitch.

So i put a stack of 64 sticks and 3-4 coal in the 2x2 crafting thats inside of the baubles inventory. Shift click to make torches, then shift click sticks out of the crafting. The sticks are duplicated.

maruohon · 2017-07-15T20:55:50Z

@PrinceOfAmber I couldn't reproduce exactly what you described, but the Container code definitely wasn't properly updated, and in my case it actually used twice the ingredient items than what it should have, when crafting. It should now be updated to what vanilla has in 1.12.

williewillus · 2017-07-21T01:04:34Z

any update on this? botania is close to complete and is waiting on this.

Lothrazar · 2017-07-30T20:34:51Z

@williewillus i havent heard anything. I want to release a modpack soon with this in 1.12 but i was waiting for it to be on curse; I dont know if i can distribute a custom built jar;doesnt feel right.

Does anyone else have access to the curse page?

I respect @Azanor 's decision to retire; so at what point should someone consider making a fork with a new curse page?

GirafiStudios · 2017-07-30T20:43:14Z

Pretty sure Azanor stated that he would still be updating Baubles.

Azanor · 2017-07-31T04:38:21Z

Sorry, I have been away for a while. I will make work of updating baubles and cleaning out some PR's this week.

Lothrazar · 2017-07-31T20:13:34Z

Awesome thanks Az! Much love!

maruohon added 8 commits June 24, 2017 16:25

Fix white spaces and some warnings

5ad68de

Update Forge and mappings, fix some deprecated method calls and warnings

61138a9

Change the API from zip to jar, include the classes. Update gradle + …

45f31b0

…wrapper.

Initial update to 1.12. Crafting related things/GUIs TODO.

e7d0d5a

Update Forge and mappings

6a539be

Update the player inventory crafting code to 1.12

d092e21

Update to Forge 2348+ and the new registry system. Update mappings.

fd3b3d0

Fix the expanded inventory background rendering (1.12 change)

783f8c3

maruohon force-pushed the MC_1.12.x_masa branch from 6306629 to 783f8c3 Compare June 24, 2017 14:28

Xalcon reviewed Jun 24, 2017

View reviewed changes

Replace a deprecated method call

3bda3e5

Xalcon reviewed Jun 24, 2017

View reviewed changes

maruohon added 7 commits June 25, 2017 02:44

Remove unnecessary @SideOnly annotations

d50135a

Create the ring item in the registry event, and use an ObjectHolder f…

3533dc3

…or it

Refactor some event handlers, to better separate the client-side ones

1c34f17

Move the PacketSync message handler into a static inner class

df5913b

Fix the modid case in the mcmod.info file

5d3e419

Update to Forge 2373

c8d4f70

Clean up the config GUI stuff

677434a

Lothrazar mentioned this pull request Jun 30, 2017

updated baubles to minecraft 1.12, forge 14.21.0.2347 #212

Closed

GirafiStudios reviewed Jun 30, 2017

View reviewed changes

maruohon added 2 commits June 30, 2017 15:06

Small clean-up to the config GUI factory. Bump Forge version and mapp…

8da6c40

…ings.

Fix tooltips not rendering in the expanded/Baubles player inventory

405cd82

Update the expanded player inventory's onContainerClosed() to 1.12

1a35c8a

Azanor merged commit 9f35fd1 into Azanor:master Aug 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port and update to MC 1.12 and the new Forge registry changes #214

Port and update to MC 1.12 and the new Forge registry changes #214

maruohon commented Jun 24, 2017

Xalcon Jun 24, 2017

Xalcon Jun 24, 2017

Xalcon Jun 24, 2017

maruohon Jun 24, 2017

Lothrazar commented Jun 30, 2017

GirafiStudios Jun 30, 2017

asiekierka commented Jun 30, 2017 •

edited

Loading

Lothrazar commented Jun 30, 2017

Lothrazar commented Jul 15, 2017

maruohon commented Jul 15, 2017

williewillus commented Jul 21, 2017

Lothrazar commented Jul 30, 2017

GirafiStudios commented Jul 30, 2017

Azanor commented Jul 31, 2017

Lothrazar commented Jul 31, 2017

		{
		public static final Item RING = (new ItemRing()).setUnlocalizedName("Ring").setRegistryName("ring");

Port and update to MC 1.12 and the new Forge registry changes #214

Port and update to MC 1.12 and the new Forge registry changes #214

Conversation

maruohon commented Jun 24, 2017

Xalcon Jun 24, 2017

Choose a reason for hiding this comment

Xalcon Jun 24, 2017

Choose a reason for hiding this comment

Xalcon Jun 24, 2017

Choose a reason for hiding this comment

maruohon Jun 24, 2017

Choose a reason for hiding this comment

Lothrazar commented Jun 30, 2017

GirafiStudios Jun 30, 2017

Choose a reason for hiding this comment

asiekierka commented Jun 30, 2017 • edited Loading

Lothrazar commented Jun 30, 2017

Lothrazar commented Jul 15, 2017

maruohon commented Jul 15, 2017

williewillus commented Jul 21, 2017

Lothrazar commented Jul 30, 2017

GirafiStudios commented Jul 30, 2017

Azanor commented Jul 31, 2017

Lothrazar commented Jul 31, 2017

asiekierka commented Jun 30, 2017 •

edited

Loading