perf: move configs to appsettings.json

Azaferany · Jul 26, 2022 · c8d1c77 · c8d1c77
1 parent 081b5b3
commit c8d1c77
Show file tree

Hide file tree

Showing 4 changed files with 62 additions and 41 deletions.
diff --git a/src/QuickstartTemplate.WebApi/Program.cs b/src/QuickstartTemplate.WebApi/Program.cs
@@ -1,31 +1,18 @@
 using QuickstartTemplate.WebApi;
 using Sentry;
 using Serilog;
-using Serilog.Events;
 
 var builder = WebApplication.CreateBuilder(args);
+// NOTE: Default application configuration sources can be found at 
+// https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-6.0#default-application-configuration-sources
 
 builder.WebHost.UseSentry((builderContext, sentryOptions) =>
 {
     sentryOptions.Dsn = builderContext.Configuration["SENTRY_DSN"];
     sentryOptions.AddExceptionFilterForType<OperationCanceledException>();
 });
 
-builder.Host.UseSerilog((context, configuration) =>
-{
-    if (!Enum.TryParse(context.Configuration["LogEventLevel"], out LogEventLevel logEventLevel))
-        logEventLevel = LogEventLevel.Information;
-
-    configuration.Filter.ByExcluding(logEvent =>
-        logEvent.Exception != null && logEvent.Exception.GetType() == typeof(OperationCanceledException));
-
-    configuration.MinimumLevel.Is(logEventLevel);
-
-    configuration.Enrich.FromLogContext();
-
-    configuration.WriteTo.Console();
-    configuration.WriteTo.Sentry();
-});
+builder.Host.UseSerilog((context, configuration) => configuration.ReadFrom.Configuration(context.Configuration));
 
 // Manually create an instance of the Startup class
 // https://andrewlock.net/exploring-dotnet-6-part-12-upgrading-a-dotnet-5-startup-based-app-to-dotnet-6/

diff --git a/src/QuickstartTemplate.WebApi/Startup.cs b/src/QuickstartTemplate.WebApi/Startup.cs
@@ -46,21 +46,12 @@ public void ConfigureServices(IServiceCollection services)
         });
 
         services.AddSwaggerGen();
-
 
-        //https://josef.codes/asp-net-core-6-http-logging-log-requests-responses/
-        services.AddHttpLogging(options =>
-        {
-            //dont log Response if grpc is added it will break; track bug in below issue
-            //https://github.com/dotnet/aspnetcore/issues/39317
-
-            HttpLoggingFields httpLoggingFields;
-            //https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.httplogging.httploggingfields?view=aspnetcore-6.0
-            if (!Enum.TryParse(_configuration["HttpLoggingFields"],
-                    out httpLoggingFields))
-                httpLoggingFields = HttpLoggingFields.None;
-            options.LoggingFields = httpLoggingFields;
-        });
+        //for more information read
+        //https://docs.microsoft.com/en-us/aspnet/core/fundamentals/http-logging/?view=aspnetcore-6.0
+        //dont log Response if grpc is added it will break; track bug in below issue
+        //https://github.com/dotnet/aspnetcore/issues/39317
+        services.AddHttpLogging(options => _configuration.Bind("HttpLogging", options));
     }
 
     public void Configure(WebApplication app)

diff --git a/src/QuickstartTemplate.WebApi/appsettings.Development.json b/src/QuickstartTemplate.WebApi/appsettings.Development.json
@@ -1,8 +1,30 @@
 {
-  "Logging": {
-    "LogLevel": {
-      "Default": "Information",
-      "Microsoft.AspNetCore": "Warning"
-    }
-  }
+  "Serilog": {
+    "MinimumLevel": {
+      "Default": "Information"
+    },
+    "WriteTo": [
+      {
+        "Name": "Console"
+      },
+      {
+        "Name": "Sentry"
+      }
+    ],
+    "Enrich": [
+      "FromLogContext"
+    ],
+    "Filter": [
+      {
+        "Name": "ByExcluding",
+        "Args": {
+          "expression": "@x is not null and TypeOf(@x) not like '%OperationCanceledException%'"
+        }
+      }
+    ]
+  },
+  "HttpLogging": {
+    "LoggingFields": "None"
+  },
+  "AllowedHosts": "*"
 }
diff --git a/src/QuickstartTemplate.WebApi/appsettings.json b/src/QuickstartTemplate.WebApi/appsettings.json
@@ -1,9 +1,30 @@
 {
-  "Logging": {
-    "LogLevel": {
-      "Default": "Information",
-      "Microsoft.AspNetCore": "Warning"
-    }
+  "Serilog": {
+    "MinimumLevel": {
+      "Default": "Information"
+    },
+    "WriteTo": [
+      {
+        "Name": "Console"
+      },
+      {
+        "Name": "Sentry"
+      }
+    ],
+    "Enrich": [
+      "FromLogContext"
+    ],
+    "Filter": [
+      {
+        "Name": "ByExcluding",
+        "Args": {
+          "expression": "@x is not null and TypeOf(@x) not like '%OperationCanceledException%'"
+        }
+      }
+    ]
+  },
+  "HttpLogging": {
+    "LoggingFields": "None"
   },
   "AllowedHosts": "*"
 }