Reduce the number of property lookups for matching entities #3119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a cache to the properties that have been discovered in each of the message payloads that an entity has a handler for. This prevents lookup of properties to occur for each instance of an event that is applied to an aggregate. With this optimization, a lookup is only required for each new payload type that is being applied.
abuijze
added
Type: Enhancement
smcvb
approved these changes
Aug 29, 2024
| @@ -0,0 +1,183 @@ | |||
| package org.axonframework.modelling.command; | |||
There was a problem hiding this comment.
You're missing the copyright notice in this new file.
| @@ -22,7 +22,9 @@ | |||
|
|
|||
| import java.lang.reflect.AnnotatedElement; | |||
There was a problem hiding this comment.
The copyright notice should've been updated by these changes.
smcvb
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache to the properties that have been discovered in each of the message payloads that an entity has a handler for.
This prevents lookup of properties to occur for each instance of an event that is applied to an aggregate.
With this optimization, a lookup is only required for each new payload type that is being applied.