Skip to content
This repository was archived by the owner on Nov 28, 2025. It is now read-only.

Port DarkKronicle's bedwars display #79

Merged
moehreag merged 46 commits into from
Jul 16, 2023
Merged

Port DarkKronicle's bedwars display #79

moehreag merged 46 commits into from
Jul 16, 2023

Conversation

@moehreag
Copy link
Member

@moehreag moehreag commented Jul 4, 2023 •
edited
Loading

Original PR: Sol-Client/client#136

Other changes

  • Add more Events

TODO

  • test the functionality, make changes as desired
  • Add the translation keys
  • port to all other versions
  • port the Event "system" to all other versions

@moehreag moehreag self-assigned this Jul 8, 2023
moehreag added a commit to moehreag/AxolotlClient-mod that referenced this pull request Jul 9, 2023
@moehreag
make the action build again
d4d9e06 
add Credits in preparation for AxolotlClient#79

this will probably make the action take a tad bit longer, but it should still be fine
@moehreag moehreag marked this pull request as ready for review July 10, 2023 18:38
@moehreag
Copy link
Member Author

moehreag commented Jul 10, 2023

Versions other than 1.8.9 are still mostly untested.

@moehreag moehreag requested a review from TheKodeToad July 10, 2023 18:40
@TheKodeToad
Copy link
Member

TheKodeToad commented Jul 10, 2023

Sybillian didn't give permission for this project which doesn't feel great.

@moehreag
Copy link
Member Author

moehreag commented Jul 10, 2023

true, we can currently only rely on what's given on the original github page

This pack was created by Sybillian. Please clearly credit if you use it as a base for other projects.

The author still seems to be active in the community and on the hypixel forums. It might be worth contacting them for certainty.

moehreag added 4 commits July 11, 2023 12:43
@moehreag
fix a bug, add option to usually hide the hud
169814d
@moehreag
re-use original footer
1f15b11 
- modify credits for Sybillian to match what is probably expected by them
@moehreag
use vanilla textures instead of custom ones
acf0abb 
- advantages: easy replacement through resourcepacks
- disadvantages: *slightly* more messy code
@moehreag
update credits to reflect the latest changes
035b404
@moehreag
Copy link
Member Author

moehreag commented Jul 11, 2023

Sybillian didn't give permission for this project which doesn't feel great.

this has now also been solved by just not needing any external textures anymore, but it might objectively look slightly worse now.

@TheKodeToad
Copy link
Member

TheKodeToad commented Jul 14, 2023

Okay... idk how I'm going to review all this 😭
14k lines is a lot :P

TheKodeToad
TheKodeToad reviewed Jul 14, 2023
View reviewed changes
Copy link
Member

@TheKodeToad TheKodeToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be considered a complete review, however i somewhat care about my sanity :D

@moehreag moehreag requested a review from TheKodeToad July 14, 2023 19:15
DarkKronicle
DarkKronicle reviewed Jul 14, 2023
View reviewed changes
@moehreag moehreag requested a review from DarkKronicle July 16, 2023 16:47
@moehreag moehreag merged commit 6c9cdc0 into AxolotlClient:multiversion Jul 16, 2023
@moehreag moehreag deleted the feat/sol/darkkronicle-bedwars-display branch July 16, 2023 16:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TheKodeToad TheKodeToad Awaiting requested review from TheKodeToad

1 more reviewer

@DarkKronicle DarkKronicle DarkKronicle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@moehreag moehreag

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moehreag @TheKodeToad @DarkKronicle