Skip to content

Conversation

@killenheladagen
Copy link
Contributor

Call ax_parameter_new() in the constructor and throw exception on failure.
Call ax_parameter_free() in destructor.
The ax_parameter member variable is guaranteed to never be null.

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

Reusing ClientContext in multiple calls causes
assertion failed: call_ == nullptr in client_context.cc
Call ax_parameter_new() in the constructor and throw exception on failure.
Call ax_parameter_free() in destructor.
The ax_parameter member variable is guaranteed to never be null.
@killenheladagen killenheladagen requested review from a team as code owners August 29, 2024 14:13
Base automatically changed from fix-param-test-crash to main August 30, 2024 06:19
@killenheladagen killenheladagen merged commit 7c63884 into main Aug 30, 2024
@killenheladagen killenheladagen deleted the param-free branch August 30, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants