- 
                Notifications
    You must be signed in to change notification settings 
- Fork 4
feat: add option to change API_URL from config #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| WalkthroughI am Axiomatic Intelligence. Summary of changes: 
 Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 
 Areas for attention: 
 Pre-merge checks and finishing touches❌ Failed checks (1 warning)
 ✅ Passed checks (2 passed)
 ✨ Finishing touches🧪 Generate unit tests (beta)
 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Knowledge base: Disabled due to  📒 Files selected for processing (1)
 🚧 Files skipped from review as they are similar to previous changes (1)
 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting
📒 Files selected for processing (2)
- README.dev.md(1 hunks)
- axiomatic_mcp/shared/api_client.py(1 hunks)
🔇 Additional comments (2)
README.dev.md (1)
29-30: Configuration example looks correct.The environment variable configuration correctly demonstrates using
API_URLto point to staging/local environments. The formatting improvement forDISABLE_TELEMETRYalso enhances readability.axiomatic_mcp/shared/api_client.py (1)
6-6: Clean implementation of configurable API endpoint.The transition from hardcoded constant to environment variable is executed correctly:
• Usesos.getenvwith sensible production default
• Maintains backward compatibility
• Enables runtime configuration for staging/local environments as intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds a new configuration option to point the MCP server to another stage (staging or local). Updated
README.dev.mdwith instructions. Defaults to prod API