Skip to content

Conversation

@a96lex
Copy link
Contributor

@a96lex a96lex commented Oct 28, 2025

Adds a new configuration option to point the MCP server to another stage (staging or local). Updated README.dev.md with instructions. Defaults to prod API

@a96lex a96lex requested a review from a team as a code owner October 28, 2025 11:54
@a96lex a96lex requested review from AdriantrejoAx and removed request for a team October 28, 2025 11:54
@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Walkthrough

I am Axiomatic Intelligence. Summary of changes:

  • API_URL in axiomatic_mcp/shared/api_client.py now reads from the API_URL environment variable with a fallback to https://api.axiomatic-ai.com instead of being a hard-coded constant.
  • README.dev.md updated: adds API_URL to MCP client env examples, adjusts DISABLE_TELEMETRY formatting, and adds a “Using staging or local environment” section describing staging/local API_URL values.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Small, focused change: one constant replaced by os.getenv() and documentation updates.
  • Low logic density and few files touched; mostly configuration and docs.

Areas for attention:

  • Confirm the fallback URL https://api.axiomatic-ai.com is the intended production endpoint.
  • Check any runtime environments (CI, deployments, local dev scripts) are updated to set API_URL when needed.
  • Ensure tests or integrations that assume the old hard-coded URL are updated or resilient to the env var.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "feat: add option to change API_URL from config" directly and clearly describes the main change in this pull request. The changeset makes the API_URL configurable via environment variables (reading from API_URL environment variable with a fallback to the production endpoint) and documents this in README.dev.md. The title accurately captures this core modification and uses appropriate conventional commit formatting with the "feat:" prefix. It is concise, specific, and would help teammates understand the primary change when scanning commit history.
Description Check ✅ Passed The pull request description is clearly related to the changeset and provides relevant context about the change. It mentions adding a configuration option to point the MCP server to different stages (staging or local), which directly aligns with making the API_URL configurable. It also correctly notes that README.dev.md was updated with instructions and that the default remains the production API. The description is sufficiently detailed to convey the intent without being verbose, and it accurately reflects what was implemented in the code changes.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/configurable-api-url

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 96df3d3 and ba893c0.

📒 Files selected for processing (1)
  • README.dev.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.dev.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between e7ab9d8 and 96df3d3.

📒 Files selected for processing (2)
  • README.dev.md (1 hunks)
  • axiomatic_mcp/shared/api_client.py (1 hunks)
🔇 Additional comments (2)
README.dev.md (1)

29-30: Configuration example looks correct.

The environment variable configuration correctly demonstrates using API_URL to point to staging/local environments. The formatting improvement for DISABLE_TELEMETRY also enhances readability.

axiomatic_mcp/shared/api_client.py (1)

6-6: Clean implementation of configurable API endpoint.

The transition from hardcoded constant to environment variable is executed correctly:
• Uses os.getenv with sensible production default
• Maintains backward compatibility
• Enables runtime configuration for staging/local environments as intended

Copy link
Contributor

@AdriantrejoAx AdriantrejoAx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdriantrejoAx AdriantrejoAx merged commit ccc73ff into main Oct 30, 2025
4 checks passed
@a96lex a96lex deleted the feat/configurable-api-url branch October 30, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants