Added .env file and filtering tests #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set docker-compose.yml env_file field on the web service. This points at a .env file in the root directory to receive environment variables. The main purpose use case is to allow for separate configurations in development and production, and to keep secrets out of the git repository. additionally this allows for the modified manage.py file to read these variables so the application can be run outside of a docker container. The primary use case for this, although it can be done with docker-compose, is to run tests: python manage.py test --settings=api.config.settings
added separate test settings file. This allows for inheriting the
default settings while overriding any configuration needed for the
test suite, for example databases.
Removed existing filter tests (were pointing at non-existant methods)
and added tests to cover current filtering functionality.
Due to environment & manage.py refactor these tests can be run outside
of a docker container:
python manage.py test --settings=api.config.test_settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
.envfile for the developer to define environment variables. It adds an extra step to set up & configuration but gives the flexibility to define local development & production builds.I also refactored the filtering tests and plan to add view/serializer tests in the future (plus travis/CI support).