Commit Message Guidelines #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drvinceknight
requested changes
Apr 3, 2017
| 3. Commits: Please try to use commit messages that give a meaningful history | ||
| for anyone using git's log features. Try to use messages that complete sentence, | ||
| "If merged, this commit will...." There is some excellent guidance on the subject | ||
| from `Chris Beams <https://chris.beams.io/posts/git-commit/>` |
Member
There was a problem hiding this comment.
I believe this needs a _ at the end for the url to be picked up properly?
`Chris Beams <https://chris.beams.io/posts/git-commit/>`_
marcharper
reviewed
Apr 3, 2017
| 3. Testing: the project uses the `unittest | ||
| 3. Commits: Please try to use commit messages that give a meaningful history | ||
| for anyone using git's log features. Try to use messages that complete sentence, | ||
| "If merged, this commit will...." There is some excellent guidance on the subject |
Member
There was a problem hiding this comment.
How about "This commit <etc.>" rather than "if merged, ..." which seems redundant.
drvinceknight
approved these changes
Apr 3, 2017
Contributor
|
@meatballs thank you for providing this. Never even thought about it before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.