Remove morality_metrics as arg for Tournament. #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On #1042 @marcharper mentioned that it was perhaps worth moving this argument out of the Tournament.init. I took a look and turns out that this argument is not being used anymore (I'm not sure since when). Probably since the move to doing the result calculations on disk.
meatballs
approved these changes
Jun 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #1042 @marcharper
mentioned that it was perhaps worth moving this argument out of the
Tournament.init.
I took a look and turns out that this argument is not being used anymore
(I'm not sure since when). Probably since the move to doing the result
calculations on disk.