Various PEP8 and style fixes

[marcharper]

No description provided.

[drvinceknight]

This all looks great to me, just the one point about space around default variable assignment. It comes under the "Other recommendations" in PEP8:

Don't use spaces around the = sign when used to indicate a keyword argument or a default parameter value.

Yes:

 def complex(real, imag=0.0):
     return magic(r=real, i=imag)

No:

def complex(real, imag = 0.0):
    return magic(r = real, i = imag)

[drvinceknight]

My linter is picking defaultdict = None (etc) up:

[bad-whitespace] No space allowed around keyword argument assignment [python/pylint]

It's happy with:

state_dist: defaultdict=None) -> None:

[marcharper]

For type hints there are supposed to be spaces, looking at the examples in its PEP, e.g.:

def func(x: Union[int, None, Empty] = _empty) -> int:

and

def embezzle(self, account: str, funds: int = 1000000, *fake_receipts: str) -> None:

[drvinceknight]

For type hints there are supposed to be spaces, looking at the examples in its PEP, e.g.:

Cool. I wondered if it might be something like this. 👍

[marcharper]

@drvinceknight Made some additional style fixes. Can you diagnose the travis issue with the docstring? I don't understand what it wants.

[drvinceknight]

I'll take a look. Note unit tests are also failing because of your attribute/method rename in dbs.

[marcharper]

Unittests fixed.

[drvinceknight]

Cool, I'm heading out for a walk but assume it's ok if I push a fix directly for the docstring later (I expect it's just sphinx being very picky about some indentation). :)

[marcharper]

Cool, I'm heading out for a walk but assume it's ok if I push a fix directly for the docstring later (I expect it's just sphinx being very picky about some indentation). :)

Please do!

[drvinceknight]

Fixing the merge conflicts now :) (Just running tests to be sure.)

[drvinceknight]

Assuming tests pass etc, I am happy with this 👍