Refactor tests for hunter. #1033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #884
meatballs
approved these changes
May 30, 2017
These lines are no longer hit by any test, this takes the coverage up to 100%. Further refactoring can take place following all the PRs for #844 are merged.
Member
Author
|
Just noticed that this had brought coverage down, because a particular part of |
marcharper
reviewed
May 31, 2017
| for response in responses: | ||
| s1, s2 = simulate_play(player1, player2) | ||
| test_class.assertEqual(s1, response) | ||
| if attrs: |
Member
There was a problem hiding this comment.
Why do we not need attrs anymore? Have all such cases been moved to versus_test?
Member
Author
There was a problem hiding this comment.
(The coverage on this PR dropped because that line wasn't being hit by anything, which is why I just removed it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #884