Refactor tests for punisher. #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes towards #884
marcharper
reviewed
May 23, 2017
| self.assertEqual(P1.grudged, False) | ||
| self.assertEqual(P1.grudge_memory, 1) | ||
| player = axelrod.Punisher() | ||
| self.assertEqual(player.history, []) |
Member
There was a problem hiding this comment.
This line is probably not necessary, or is better as a generic player test in test_player.py.
Member
Author
There was a problem hiding this comment.
Yeah good call. I'll clean this up now 👍
Member
Author
There was a problem hiding this comment.
Just checked and it already is a generic player test :)
marcharper
reviewed
May 23, 2017
| self.assertEqual(P1.grudged, False) | ||
| self.assertEqual(P1.grudge_memory, 1) | ||
| player = axelrod.InversePunisher() | ||
| self.assertEqual(player.history, []) |
marcharper
approved these changes
May 24, 2017
marcharper
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #884