Skip to content

Commit

Permalink
[rootx] Remove "core developers" from splash window:
Browse files Browse the repository at this point in the history
We do not show this anymore, and this requires complex operations and
- in its current implementation - a working ROOT build as part of the
version update.
  • Loading branch information
Axel-Naumann committed Sep 13, 2023
1 parent c1dbe06 commit 9b2b237
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 89 deletions.
23 changes: 0 additions & 23 deletions build/unix/coreteam.sh

This file was deleted.

38 changes: 0 additions & 38 deletions rootx/src/rootcoreteam.h

This file was deleted.

25 changes: 1 addition & 24 deletions rootx/src/rootxx-cocoa.mm
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
#include "RConfigure.h"
#include "RVersion.h"

#include "rootcoreteam.h"

namespace {
#ifdef MAC_OS_X_VERSION_10_12
const NSCompositingOperation kCompositeSourceOver = NSCompositingOperationSourceOver;
Expand Down Expand Up @@ -867,7 +865,7 @@ void SetSplashscreenPosition()
//Aux. "non-GUI" functions.

//
//Caption like "Conception"/"Core Developers"/"Contributors" - white and bold.
// Caption like "Conception"/"Contributors" - white and bold.
//

//_________________________________________________________________
Expand Down Expand Up @@ -997,27 +995,6 @@ bool AddDeveloperInfo(NSMutableAttributedString *textToScroll)
//TODO: diagnostic.
return false;

if (!AddSectionTitle(textToScroll, @"Core Engineering: "))
//TODO: diagnostic.
return false;

std::size_t nLines = sizeof ROOT::ROOTX::gROOTCoreTeam / sizeof ROOT::ROOTX::gROOTCoreTeam[0];
if (nLines > 1) {
nLines -= 1;//There is a "terminating null" in this array, get rid of it.

NSScopeGuard<NSMutableString> coreTeam([[NSMutableString alloc] init]);

for (std::size_t i = 0; i < nLines; ++i)
[coreTeam.Get() appendFormat : (i ? @", %s" : @"%s"), ROOT::ROOTX::gROOTCoreTeam[i]];
[coreTeam.Get() appendFormat : @".\n\n"];

if (!AddSectionBody(textToScroll, coreTeam.Get()))
return false;
} else {
//TODO: diagnostic.
return false;
}

return true;
}

Expand Down
4 changes: 0 additions & 4 deletions rootx/src/rootxx.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
#include "snprintf.h"
#include "strlcpy.h"

#include "rootcoreteam.h"

#if defined(R__AIX) || defined(R__SOLARIS)
# include <sys/select.h>
#endif
Expand Down Expand Up @@ -767,8 +765,6 @@ int DrawCredits(bool draw, bool extended)
y = DrawCreditItem("Conception: ", gConception, y, draw);
y += 2 * lineSpacing;

y = DrawCreditItem("Core Engineering: ", ROOT::ROOTX::gROOTCoreTeam, y, draw);

if (extended && gContributors) {
y += 2 * lineSpacing;
y = DrawCreditItem("Contributors: ", (const char **)gContributors, y, draw);
Expand Down

0 comments on commit 9b2b237

Please sign in to comment.