refactor(lint): Fix minor lint issues

- Imports, unused variables,
- deprecated use of substr replaced with slice.
- remove await on non awaitable code.

examples/react-oidc-demo/src/MultiAuth.tsx

@@ -16,7 +16,7 @@ const fetchWithLogs = (fetch: Fetch) => async (...params: Parameters<Fetch>) =>
     return await fetch(url, options, ...rest);
 };
 
-const MultiAuth = ({ configurationName, handleConfigurationChange }) => {;
+const MultiAuth = ({ configurationName, handleConfigurationChange }) => {
     const { login, logout, isAuthenticated } = useOidc(configurationName);
     const { isAuthenticated: isAuthenticatedDefault } = useOidc('default');
     const [fname, setFname] = useState('');

packages/oidc-client-service-worker/src/OidcServiceWorker.ts

@@ -15,11 +15,11 @@ import {
 	getDomains,
 	hideTokens,
 	isTokensValid,
+	normalizeUrl,
 	serializeHeaders,
 	sleep,
 } from './utils';
 import {extractConfigurationNameFromCodeVerifier, replaceCodeVerifier} from './utils/codeVerifier';
-import { normalizeUrl } from './utils/normalizeUrl';
 import version from './version';
 
 // @ts-ignore

packages/oidc-client/src/checkSession.ts

@@ -42,8 +42,7 @@ export const startCheckSessionAsync = (oidc:Oidc, oidcDatabase:any, configuratio
 
                 }).catch(async (e) => {
                     console.warn('SessionMonitor._callback: Silent login failed, logging out other tabs:', e);
-                    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-                    for (const [key, oidc] of Object.entries(oidcDatabase)) {
+                    for (const [, oidc] of Object.entries(oidcDatabase)) {
                         // @ts-ignore
                         await oidc.logoutOtherTabAsync(configuration.client_id, idTokenPayload.sub);
                     }

packages/oidc-client/src/checkSessionIFrame.ts

@@ -19,7 +19,7 @@ export class CheckSessionIFrame {
         this._interval = interval || DefaultInterval;
         this._stopOnError = stopOnError;
         const idx = url.indexOf('/', url.indexOf('//') + 2);
-        this._frame_origin = url.substr(0, idx);
+        this._frame_origin = url.substring(0, idx);
         this._frame = window.document.createElement('iframe');
         this._frame.style.visibility = 'hidden';
         this._frame.style.position = 'absolute';

packages/oidc-client/src/oidc.ts

@@ -316,7 +316,7 @@ Please checkout that you are using OIDC hook inside a <OidcProvider configuratio
 
         const session = initSession(this.configurationName, configuration.storage);
         const jwk = await session.getDemonstratingProofOfPossessionJwkAsync();
-        const demonstratingProofOfPossessionNonce = await session.getDemonstratingProofOfPossessionNonce();
+        const demonstratingProofOfPossessionNonce = session.getDemonstratingProofOfPossessionNonce();
 
         if (demonstratingProofOfPossessionNonce) {
             claimsExtras['nonce'] = demonstratingProofOfPossessionNonce;

packages/oidc-client/src/oidcClient.ts

@@ -9,7 +9,7 @@ export interface EventSubscriber {
 }
 
 export class OidcClient {
-    private _oidc: Oidc;
+    private readonly _oidc: Oidc;
     constructor(oidc: Oidc) {
         this._oidc = oidc;
     }

packages/oidc-client/src/silentLogin.ts

@@ -61,7 +61,7 @@ export const _silentLoginAsync = (configurationName:string, configuration:OidcCo
                 isResolved = true;
             };
 
-            const listener = (e: MessageEvent<any>) => {
+            const listener = (e: MessageEvent) => {
                 if (e.origin === iFrameOrigin &&
                     e.source === iframe.contentWindow
                 ) {

packages/react-oidc/src/core/routes/withRouter.tsx

@@ -1,7 +1,7 @@
 const generateKey = () =>
   Math.random()
     .toString(36)
-    .substr(2, 6);
+    .slice(2, 8);
 
 // Exported only for test
 export type WindowInternal = Window & {