Skip to content

fix(look&feel,apollo): ensure overflow is hidden in progress bar styles #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2025
Merged

fix(look&feel,apollo): ensure overflow is hidden in progress bar styles #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210e485
fix(look&feel,apollo): ensure overflow is hidden in progress bar styles
GuillaumeKESTEMAN Oct 16, 2025
235e35a
fix(apollo,look&feel): import Stepper from apollo/lf in the story
GuillaumeKESTEMAN Oct 16, 2025
bc72205
feat(look&feel,apollo): set to ProgressBar a progress value border ra…
GuillaumeKESTEMAN Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/look-and-feel-stories/src/Stepper/Stepper.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as StepperStories from "./Stepper.stories";
To use the header import it like that:

```tsx
import { Stepper } from "@axa-fr/design-system-look-and-feel-react";
import { Stepper } from "@axa-fr/design-system-apollo-react/lf";

const MyComponent = () => <Stepper />;
```
Expand Down
6 changes: 3 additions & 3 deletions apps/look-and-feel-stories/src/Stepper/Stepper.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Stepper } from "@axa-fr/design-system-look-and-feel-react";
import { Stepper } from "@axa-fr/design-system-apollo-react/lf";
import type { Meta, StoryObj } from "@storybook/react";
import { ComponentProps } from "react";

Expand Down Expand Up @@ -31,6 +31,6 @@ export const Playground: Story = {
helper: "Sauf mention du contraire, tous les champs sont obligatoires.",
},
argTypes: {
messageType: { control: 'select', options: ['error', 'success'] },
}
messageType: { control: "select", options: ["error", "success"] },
},
};
3 changes: 3 additions & 0 deletions client/apollo/css/src/ProgressBar/ProgressBarCommon.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
height: calc(6 / var(--font-size-base) * 1rem);
border: none;
border-radius: var(--progress-bar-radius);
overflow: hidden;
background-color: var(--progress-bar-background-color);
appearance: var(--progress-bar-appearance);

Expand All @@ -14,12 +15,14 @@

/* For WebKit browsers */
&::-webkit-progress-value {
border-radius: var(--progress-bar-radius);
background-color: var(--progress-bar-appearance);
transition: width 0.75s ease;
}

/* For Firefox */
&::-moz-progress-bar {
border-radius: var(--progress-bar-radius);
background-color: var(--progress-bar-appearance);

/* transition doesn't work in Firefox for native progress bars */
Expand Down