[GrantShares] GBA-04 Safe Storage Access

[OT-kraftchain]

The safe bridgeVersion method does not use asReadOnly() when accessing storage. In N3, different types of storage access exist, with the ReadOnly Context being the most suitable for read-only methods. Using a read-only context ensures that no unintended or malicious state
modifications can occur. As in the rest of the cases, it is important to follow the Principle of Least Privilege (PoLP) in order to avoid future problems.

Recommendations
• Add asReadOnly() to the storage access of the bridgeVersion method.

References
• https://en.wikipedia.org/wiki/Principle_of_least_privilege

Source Code References

grantshares-contracts/src/main/java/com/axlabs/neo/grantshares/GrantSharesBridgeAdapter.java

Line 83 in 728d55b

return Storage.getInt(context, BRIDGE_VERSION_KEY);