Skip to content

Conversation

@rkfg
Copy link
Contributor

@rkfg rkfg commented Jul 18, 2024

This PR hides zero last retry timestamps that are displayed as 1970/01/01 00:00:00 (misleading) and also improves the dark theme. Without this patch the white rows also have white text in them so the text is invisible unless you point at them, pink rows also have white text that's hard to read, and the reconnect button's color is too bright.

@awesome-manuel
Copy link
Member

Thanks for your contribution. Can you please post some pre and post screenshots, so that I get an impression what exactly is fixed?

@rkfg
Copy link
Contributor Author

rkfg commented Jul 18, 2024

Sure, here's what it looks like now:
2024-07-18_21-27-04
and with the patch:
2024-07-18_21-27-41

Maybe the black background isn't the best choice and instead we should use the default from the theme?

@awesome-manuel
Copy link
Member

Yes, also instead of #ffcccc a theme color should be used.

@rkfg
Copy link
Contributor Author

rkfg commented Jul 18, 2024

Setting the color to undefined (for the non-highlighted rows) is much better!
2024-07-18_21-39-10
I'm not sure what color to use from the theme.

@rkfg
Copy link
Contributor Author

rkfg commented Jul 18, 2024

How about this?
2024-07-18_21-58-06
2024-07-18_21-58-01
I used the warning color from the theme and a slight button color correction. Without that it looks bad:
2024-07-18_21-59-00

@rkfg
Copy link
Contributor Author

rkfg commented Jul 19, 2024

Alternatively, using the error color with lighten by 0.5 (otherwise it's too aggresively red):
2024-07-19_13-02-55
2024-07-19_13-02-49

Tell me what you prefer.

beastafk added a commit to etkecc/synapse-admin that referenced this pull request Sep 5, 2024
aine-etke pushed a commit to etkecc/synapse-admin that referenced this pull request Sep 5, 2024
…ate (#19)

Federation page improvements
This is almost a copy of Awesome-Technologies/synapse-admin#583 PR,
authored by @rkfg
@dklimpel
Copy link
Contributor

@jk779
Copy link

jk779 commented Nov 4, 2024

can we merge this? 😎 the white theme burns my skin! ;)

@rkfg
Copy link
Contributor Author

rkfg commented Nov 4, 2024

It should now use the theme colors.

@jk779
Copy link

jk779 commented Nov 4, 2024

looks good! :)

SCR-20241104-nyut

@awesome-manuel awesome-manuel merged commit d5c10b6 into Awesome-Technologies:master May 9, 2025
dklimpel added a commit to dklimpel/synapse-admin that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants