Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codepen implemention link added #20

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shreyakapoor08
Copy link
Contributor

Fixes #17
Codepen implemention link added.
image

Copy link
Collaborator

@yellowwoods12 yellowwoods12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait for @plxity to resolve merge conflicts.

@shreyakapoor08
Copy link
Contributor Author

@plxity Kindly review

@shreyakapoor08
Copy link
Contributor Author

@yellowwoods12 @plxity Kindly review this PR, It's been more than a month.
Thanks

README.md Outdated
@@ -23,3 +23,6 @@ You can run tests by `npm test`, which would launch the test runner in the inter
## Deployment

To build the website, run `npm run build` . This would create a new `public` folder, which can be used to deploy the app on a production server.

## Code Pen Implemention Link
Check [this](https://codepen.io/) for implemention purpose.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No link is present, can you please check again?

@shreyakapoor08
Copy link
Contributor Author

@plxity Is it fine now.? I guess there were some merge conflicts before

@shreyakapoor08
Copy link
Contributor Author

@plxity any update on this pr ?

Copy link
Contributor

@plxity plxity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please show me the link?
Screenshot from 2020-05-30 00-35-40

README.md Outdated
@@ -24,5 +24,7 @@ You can run tests by `npm test`, which would launch the test runner in the inter

To build the website, run `npm run build` . This would create a new `public` folder, which can be used to deploy the app on a production server.

## Code Pen Implemention Link
Check [this](https://codepen.io/) for implemention purpose.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyakapoor08 Still no link is present. Please check.

@shreyakapoor08
Copy link
Contributor Author

@plxity

https://codepen.io/

is this not the link?

@plxity
Copy link
Contributor

plxity commented May 29, 2020

@plxity

https://codepen.io/

is this not the link?

Link to what? Do you want the user to redirect to codepen website?

@shreyakapoor08
Copy link
Contributor Author

shreyakapoor08 commented May 29, 2020

@plxity Yes, I suppose that's what was asked in the issue.

Add codepen implementation link in Readme.md #17

@plxity
Copy link
Contributor

plxity commented May 29, 2020

As the issue states, add codepen implementation link. So this link doesn't have any implementation? I hope I'm clear.

@yellowwoods12
Copy link
Collaborator

yellowwoods12 commented May 30, 2020

@plxity Yes, I suppose that's what was asked in the issue.

Add codepen implementation link in Readme.md #17

@shreyakapoor08 This issue requires the implementation of this website on codepen and that link has to be added in the Readme.md.

@shreyakapoor08
Copy link
Contributor Author

@plxity @yellowwoods12 Please check now, is it fine ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codepen implementation link in Readme.md
3 participants