Skip to content

Conversation

@lee-40square
Copy link
Contributor

Simple solution to add ui-router support. Resolves issue #1.

@lee-40square
Copy link
Contributor Author

Actually, I was thinking that this PR is kinda shit. Would be better if there was a switch that could be set to choose between ui-router or ngRoute. The way it is now it assumes that if it isn't ngRoute it's ui-router which is kinda a hack. Let me fix this and push an update.

@AvraamMavridis
Copy link
Owner

Hey, Lee. Yeah a switch will be better. Thx for the contribution. I suggest ngRoute as default.

@lee-40square
Copy link
Contributor Author

I'm working on a better solution that uses the $injector.has() method but running into a scope problem at the moment. I probably won't be able to get back to this until next week. So far try/catch is the best solution. A wrapper solution would be really nice but not sure it's worth the effort.

@AvraamMavridis
Copy link
Owner

I will merge this PR, since is good enough. And I will take a look when I have time for a wrapper solution. Thx.

AvraamMavridis added a commit that referenced this pull request Nov 13, 2015
@AvraamMavridis AvraamMavridis merged commit 4d93b8c into AvraamMavridis:master Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants