Skip to content

Commit

Permalink
chore: remove redundant CSS editors (microsoft#4092)
Browse files Browse the repository at this point in the history
# Description

<!--- Describe your changes. -->
This is the removal of the components `<CSSEditor />` and `<CSSPropertyEditor />` both of which were not exported after the shift to v2.0, they are being removed now due to careful consideration on a CSS solution for the tooling which is outlined in microsoft#3773

## Issue type checklist

<!--- What type of change are you submitting? Put an x in the box that applies: -->

- [x] **Chore**: A change that does not impact distributed packages.
- [ ] **Bug fix**: A change that fixes an issue, link to the issue above.
- [ ] **New feature**: A change that adds functionality.

**Is this a breaking change?**
- [ ] This change causes current functionality to break.

<!--- If yes, describe the impact. -->

**Adding or modifying component(s) in `@microsoft/fast-components` checklist**

<!-- Do your changes add or modify components in the @microsoft/fast-components package? Put an x in the box that applies: -->

- [ ] I have added a new component
- [ ] I have modified an existing component
- [ ] I have updated the [definition file](https://github.com/Microsoft/fast/blob/master/packages/web-components/fast-components/CONTRIBUTING.md#definition)
- [ ] I have updated the [configuration file](https://github.com/Microsoft/fast/blob/master/packages/web-components/fast-components/CONTRIBUTING.md#configuration)

## Process & policy checklist

<!--- Review the list and check the boxes that apply. -->

- [ ] I have added tests for my changes.
- [x] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the [CONTRIBUTING](https://github.com/Microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://www.fast.design/docs/community/code-of-conduct/#our-standards) for this project.

<!---
Formatting guidelines:

Accepted peer review title format:
<type>: <description>

Example titles:
    chore: add unit tests for all components
    feat: add a border radius to button
    fix: update design system to use 3px border radius

    <type> is required to be one of the following:

        - chore: A change that does not impact distributed packages.
        - fix: A change which fixes an issue.
        - feat: A that adds functionality.

    <description> is required for the CHANGELOG and speaks to what the user gets from this PR:

        - Be concise.
        - Use all lowercase characters. 
        - Use imperative, present tense (e.g. `add` not `adds`.)
        - Do not end your description with a period.
        - Avoid redundant words.

For additional information regarding working on FAST, check out our documentation site:
https://www.fast.design/docs/community/contributor-guide
-->
  • Loading branch information
janechu authored Nov 5, 2020
1 parent 9fd075b commit 339d661
Show file tree
Hide file tree
Showing 71 changed files with 3 additions and 5,735 deletions.
29 changes: 1 addition & 28 deletions packages/tooling/fast-tooling-react/app/app.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,8 @@ import { BrowserRouter, Link, Redirect, Route, Switch } from "react-router-dom";
import { NavigationTestPage } from "./pages/navigation";
import ViewerPage from "./pages/viewer";
import ViewerContentPage from "./pages/viewer/content";
import { CSSEditorTestPage } from "./pages/css-editor";
import { StyleEditorsTestPage } from "./pages/style-editors";
import { FormTestPage } from "./pages/form";
import { FormAndNavigationTestPage } from "./pages/form-and-navigation";
import { CSSPropertyEditorTestPage } from "./pages/css-property-editor";
import { NavigationMenuTestPage } from "./pages/navigation-menu";
import { WebComponentTestPage } from "./pages/web-components";
import WebComponentViewerContent from "./pages/web-components/web-component-viewer-content";
Expand All @@ -24,21 +21,6 @@ class App extends React.Component<{}, {}> {
path={"/navigation-menu"}
component={NavigationMenuTestPage}
/>
<Route
exact={true}
path={"/css-editor"}
component={CSSEditorTestPage}
/>
<Route
exact={true}
path={"/css-property-editor"}
component={CSSPropertyEditorTestPage}
/>
<Route
exact={true}
path={"/style-editors"}
component={StyleEditorsTestPage}
/>
<Route
exact={true}
path={"/navigation"}
Expand Down Expand Up @@ -67,7 +49,7 @@ class App extends React.Component<{}, {}> {
component={WebComponentViewerContent}
/>
<Route exact={true} path={"/"}>
<Redirect to={"/web-components"} />
<Redirect to={"/form"} />
</Route>
</Switch>
</div>
Expand All @@ -83,15 +65,6 @@ class App extends React.Component<{}, {}> {
<li>
<Link to="/navigation-menu">Navigation Menu</Link>
</li>
<li>
<Link to="/css-editor">CSS Editor</Link>
</li>
<li>
<Link to="/css-property-editor">CSS Property Editor</Link>
</li>
<li>
<Link to="/style-editors">Style Editors</Link>
</li>
<li>
<Link to="/form">Form</Link>
</li>
Expand Down
38 changes: 0 additions & 38 deletions packages/tooling/fast-tooling-react/app/pages/css-editor.tsx

This file was deleted.

This file was deleted.

36 changes: 0 additions & 36 deletions packages/tooling/fast-tooling-react/app/pages/style-editors.tsx

This file was deleted.

4 changes: 2 additions & 2 deletions packages/tooling/fast-tooling-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"coverageThreshold": {
"global": {
"statements": 80,
"branches": 60,
"functions": 77,
"branches": 59,
"functions": 76,
"lines": 80
}
},
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 339d661

Please sign in to comment.